ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

WIP

Browse Source
This commit is contained in:
Adam Chalmers
2025-07-03 13:54:21 -05:00
parent a948ab23cc
commit 052ebaee9b
2 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
e2e/playwright/editor-tests.spec.ts
View File

@ -573,7 +573,7 @@ sketch_001 = startSketchOn(XY)
await expect(page.locator('.cm-lint-marker-info')).toBeVisible() await expect(page.locator('.cm-lint-marker-info')).toBeVisible()
// error in guter // error in gutter
await expect(page.locator('.cm-lint-marker-info').first()).toBeVisible() await expect(page.locator('.cm-lint-marker-info').first()).toBeVisible()
// error text on hover // error text on hover

9
rust/kcl-lib/src/lint/checks/offset_plane.rs
View File

@ -215,8 +215,15 @@ pub fn common(
z_axis: x_vec.axes_cross_product(&y_vec), z_axis: x_vec.axes_cross_product(&y_vec),
}; };
let plane_equal_excluding_z = |plane: &&PlaneInfo, plane_info: &PlaneInfo| {
plane.origin == plane_info.origin && plane.x_axis == plane_info.x_axis && plane.y_axis == plane_info.y_axis
};
// Return early if we have a default plane. // Return early if we have a default plane.
if let Some((name, _)) = DEFAULT_PLANE_INFO.iter().find(|(_, plane)| **plane == plane_info) { if let Some((name, _)) = DEFAULT_PLANE_INFO
.iter()
.find(|(_, plane)| plane_equal_excluding_z(plane, &plane_info))
{
return Ok(Some((call_source_range, *name, 0.0))); return Ok(Some((call_source_range, *name, 0.0)));
} }