ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX]: "Connecting to engine" overlay shows too often (#6350)

Browse Source 
* Use the engineStreamState that's available right there silly

* fix lint

* Just look at playing/paused

---------

Co-authored-by: Jace Browning <jacebrowning@gmail.com>
This commit is contained in:
Frank Noirot
2025-04-17 08:49:31 -04:00
committed by GitHub
parent bab79331cb
commit 056a4d4a22
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/components/EngineStream.tsx
View File

@ -5,10 +5,7 @@ import { useModelingContext } from '@src/hooks/useModelingContext'
import { useNetworkContext } from '@src/hooks/useNetworkContext' import { useNetworkContext } from '@src/hooks/useNetworkContext'
import { NetworkHealthState } from '@src/hooks/useNetworkStatus' import { NetworkHealthState } from '@src/hooks/useNetworkStatus'
import { getArtifactOfTypes } from '@src/lang/std/artifactGraph' import { getArtifactOfTypes } from '@src/lang/std/artifactGraph'
import { import { EngineCommandManagerEvents } from '@src/lang/std/engineConnection'
EngineCommandManagerEvents,
EngineConnectionStateType,
} from '@src/lang/std/engineConnection'
import { btnName } from '@src/lib/cameraControls' import { btnName } from '@src/lib/cameraControls'
import { PATHS } from '@src/lib/paths' import { PATHS } from '@src/lib/paths'
import { sendSelectEventToEngine } from '@src/lib/selections' import { sendSelectEventToEngine } from '@src/lib/selections'
@ -430,8 +427,9 @@ export const EngineStream = (props: {
} }
menuTargetElement={videoWrapperRef} menuTargetElement={videoWrapperRef}
/> />
{engineCommandManager.engineConnection?.state.type !== {![EngineStreamState.Playing, EngineStreamState.Paused].some(
EngineConnectionStateType.ConnectionEstablished && ( (s) => s === engineStreamState.value
) && (
<Loading dataTestId="loading-engine" className="fixed inset-0"> <Loading dataTestId="loading-engine" className="fixed inset-0">
Connecting to engine Connecting to engine
</Loading> </Loading>