ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix unclickable state while opening share link in browser (#6201)

Browse Source 
* Fix unclickable state, don't show warning if query present

* Leave a note about need for a web test

* Fix browser share links by waiting for network connection

* Don't worry about engineConnection on home route
This commit is contained in:
Frank Noirot
2025-04-08 13:10:49 -04:00
committed by GitHub
parent c3097aa334
commit 0bb5797377
3 changed files with 29 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/components/DownloadAppBanner.tsx
View File

@ -2,12 +2,16 @@ import { Dialog } from '@headlessui/react'
import { useState } from 'react'
import { ActionButton } from '@src/components/ActionButton'
import { CREATE_FILE_URL_PARAM } from '@src/lib/constants'
import { useSettings } from '@src/machines/appMachine'
import { useSearchParams } from 'react-router-dom'
const DownloadAppBanner = () => {
const [searchParams] = useSearchParams()
const settings = useSettings()
const [isBannerDismissed, setIsBannerDismissed] = useState(
settings.app.dismissWebBanner.current
searchParams.has(CREATE_FILE_URL_PARAM) ||
settings.app.dismissWebBanner.current
)
return (
@ -43,7 +47,7 @@ const DownloadAppBanner = () => {
<ActionButton
Element="externalLink"
to="https://zoo.dev/modeling-app/download"
className="group text-warn-10 dark:!text-warn-10 pr-1 border-warn-70 hover:border-warn-80 dark:!border-warn-70 dark:hover:!border-warn-80 bg-warn-70 group-hover:bg-warn-80 dark:bg-warn-70 dark:group-hover:bg-warn-80"
className="group !text-warn-10 pr-1 border-warn-70 hover:border-warn-80 dark:!border-warn-70 dark:hover:!border-warn-80 bg-warn-70 group-hover:bg-warn-80 dark:bg-warn-70 dark:group-hover:bg-warn-80"
iconEnd={{
icon: 'arrowRight',
iconClassName: 'text-warn-10 dark:text-warn-10',