SketchOnFace UI (#1664)

* always enter edit mode

* initial blocking of extra code-mirror updates

* dry out code

* rejig selections

* A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu)

* clean up

* stream clean up

* update export

* sketch mode can be entered and exited for extrude faces

But has bugs

* startSketchOn working in some cases, editsketch animation working but not orientation of instersection plane etc

* Revert "A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu)"

This reverts commit 406fca4c55.

* A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu)

* remove comment

* add sketch on face e2e test

* tweenCamToNegYAxis should respect reduced motion

* initial sketch on face working with test

* remove temporary toolbar button and xState flow

* un-used vars

* snapshot test tweak

* A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu)

* type tidy up

* Revert "A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu)"

This reverts commit c39b8ebf95.

* Revert "A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu)"

This reverts commit fecf6f490a.

* A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu)

* rename

* sketch on sketch on sketch

* A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu)

* typo

* startSketchOn Endcaps

end works, start is weird still

* clear selections for entity_ids that are not recognised

* fix sketch on end cap of second order extrustion

* tiny clean up

* fix sketch on close segment/face

* clean up 'lastCodeMirrorSelectionUpdatedFromScene'

* add code mode test for sketchOnExtrudedFace

* make end cap selection more robust

* update js artifacts for extrudes

* update kcl docs

* clean up

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

src/lang/modifyAst.ts

@@ -1,4 +1,3 @@
-import { ToolTip } from '../useStore'
 import { Selection } from 'lib/selections'
 import {
   Program,
@@ -64,7 +63,6 @@ export function addStartProfileAt(
   pathToNode: PathToNode,
   at: [number, number]
 ): { modifiedAst: Program; pathToNode: PathToNode } {
-  console.log('addStartProfileAt called')
   const variableDeclaration = getNodeFromPath<VariableDeclaration>(
     node,
     pathToNode,
@@ -317,17 +315,17 @@ export function extrudeSketch(
 export function sketchOnExtrudedFace(
   node: Program,
   pathToNode: PathToNode,
-  programMemory: ProgramMemory
+  programMemory: ProgramMemory,
+  cap: 'none' | 'start' | 'end' = 'none'
 ): { modifiedAst: Program; pathToNode: PathToNode } {
   let _node = { ...node }
   const newSketchName = findUniqueName(node, 'part')
-  const { node: oldSketchNode, shallowPath: pathToOldSketch } =
-    getNodeFromPath<VariableDeclarator>(
-      _node,
-      pathToNode,
-      'VariableDeclarator',
-      true
-    )
+  const { node: oldSketchNode } = getNodeFromPath<VariableDeclarator>(
+    _node,
+    pathToNode,
+    'VariableDeclarator',
+    true
+  )
   const oldSketchName = oldSketchNode.id.name
   const { node: expression } = getNodeFromPath<CallExpression>(
     _node,
@@ -335,42 +333,44 @@ export function sketchOnExtrudedFace(
     'CallExpression'
   )
 
-  const { modifiedAst, tag } = addTagForSketchOnFace(
-    {
-      previousProgramMemory: programMemory,
-      pathToNode,
-      node: _node,
-    },
-    expression.callee.name
-  )
-  _node = modifiedAst
+  let _tag = ''
+  if (cap === 'none') {
+    const { modifiedAst, tag } = addTagForSketchOnFace(
+      {
+        previousProgramMemory: programMemory,
+        pathToNode,
+        node: _node,
+      },
+      expression.callee.name
+    )
+    _tag = tag
+    _node = modifiedAst
+  } else {
+    _tag = cap.toUpperCase()
+  }
 
   const newSketch = createVariableDeclaration(
     newSketchName,
-    createPipeExpression([
-      createCallExpressionStdLib('startSketchAt', [
-        createArrayExpression([createLiteral(0), createLiteral(0)]),
-      ]),
-      createCallExpressionStdLib('lineTo', [
-        createArrayExpression([createLiteral(1), createLiteral(1)]),
-        createPipeSubstitution(),
-      ]),
-      createCallExpression('transform', [
-        createCallExpressionStdLib('getExtrudeWallTransform', [
-          createLiteral(tag),
-          createIdentifier(oldSketchName),
-        ]),
-        createPipeSubstitution(),
-      ]),
+    createCallExpressionStdLib('startSketchOn', [
+      createIdentifier(oldSketchName),
+      createLiteral(_tag),
     ]),
     'const'
   )
-  const expressionIndex = getLastIndex(pathToOldSketch)
+
+  const expressionIndex = pathToNode[1][0] as number
   _node.body.splice(expressionIndex + 1, 0, newSketch)
+  const newpathToNode: PathToNode = [
+    ['body', ''],
+    [expressionIndex + 1, 'index'],
+    ['declarations', 'VariableDeclaration'],
+    [0, 'index'],
+    ['init', 'VariableDeclarator'],
+  ]
 
   return {
     modifiedAst: _node,
-    pathToNode: [...pathToNode.slice(0, -1), [expressionIndex, 'index']],
+    pathToNode: newpathToNode,
   }
 }