ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prevent double-click to constrain length on unsupported lines (#5938)

Browse Source 
* WIP: Prevent length constraint creation on endAbsolute lines
Fixes #5937

* Typo

Thanks @franknoirot

Co-authored-by: Frank Noirot <frank@zoo.dev>

* length constraint stuff from @lrev-Dev

* Clean up

* Lint

* Add regression test for double click after sketch constraint

---------

Co-authored-by: Frank Noirot <frank@zoo.dev>
Co-authored-by: Kurt Hutten Irev-Dev <k.hutten@protonmail.ch>
This commit is contained in:
Pierre Jacquier
2025-04-02 10:52:36 -04:00
committed by GitHub
parent d168ef94e9
commit 10c1f3a849
7 changed files with 116 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
e2e/playwright/testing-constraints.spec.ts
View File

@ -1098,7 +1098,7 @@ test.describe('Electron constraint tests', () => {
test(
'Able to double click label to set constraint',
{ tag: '@electron' },
async ({ page, context, homePage, scene, editor, toolbar }) => {
async ({ page, context, homePage, scene, editor, toolbar, cmdBar }) => {
await context.folderSetupFn(async (dir) => {
const bracketDir = path.join(dir, 'test-sample')
await fsp.mkdir(bracketDir, { recursive: true })
@ -1132,6 +1132,14 @@ test.describe('Electron constraint tests', () => {
await scene.waitForExecutionDone()
})
async function clickOnFirstSegmentLabel() {
const child = page
.locator('.segment-length-label-text')
.first()
.locator('xpath=..')
await child.dblclick()
}
await test.step('Double click to constrain', async () => {
// Enter sketch edit mode via feature tree
await toolbar.openPane('feature-tree')
@ -1139,21 +1147,19 @@ test.describe('Electron constraint tests', () => {
await op.dblclick()
await toolbar.closePane('feature-tree')
const child = page
.locator('.segment-length-label-text')
.first()
.locator('xpath=..')
await child.dblclick()
const cmdBarSubmitButton = page.getByRole('button', {
name: 'arrow right Continue',
})
await cmdBarSubmitButton.click()
await expect(page.locator('.cm-content')).toContainText(
'length001 = 15.3'
)
await expect(page.locator('.cm-content')).toContainText(
'|> angledLine([9, length001], %)'
)
await clickOnFirstSegmentLabel()
await cmdBar.progressCmdBar()
await editor.expectEditor.toContain('length001 = 15.3')
await editor.expectEditor.toContain('|> angledLine([9, length001], %)')
})
await test.step('Double click again and expect failure', async () => {
await clickOnFirstSegmentLabel()
await expect(
page.getByText('Unable to constrain the length of this segment')
).toBeVisible()
await page.getByRole('button', { name: 'Exit Sketch' }).click()
})
}