ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

UI fix for comment settings collision (#6249)

Browse Source 
* UI fix for comment settings collision

* fmt

* Fix tsc by using Promise.reject

---------

Co-authored-by: Frank Noirot <frankjohnson1993@gmail.com>
This commit is contained in:
Kurt Hutten
2025-04-12 00:16:45 +10:00
committed by GitHub
parent c6ec54c138
commit 121c393466
4 changed files with 36 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/components/ModelingMachineProvider.tsx
View File

@ -760,7 +760,8 @@ export const ModelingMachineProvider = ({
// remove body item at varDecIndex
newAst.body = newAst.body.filter((_, i) => i !== varDecIndex)
await kclManager.executeAstMock(newAst)
const didReParse = await kclManager.executeAstMock(newAst)
if (err(didReParse)) return reject(didReParse)
await codeManager.updateEditorWithAstAndWriteToFile(newAst)
}
sceneInfra.setCallbacks({
@ -773,6 +774,7 @@ export const ModelingMachineProvider = ({
'animate-to-face': fromPromise(async ({ input }) => {
if (!input) return null
if (input.type === 'extrudeFace' || input.type === 'offsetPlane') {
const originalCode = codeManager.code
const sketched =
input.type === 'extrudeFace'
? sketchOnExtrudedFace(
@ -791,7 +793,13 @@ export const ModelingMachineProvider = ({
}
const { modifiedAst, pathToNode: pathToNewSketchNode } = sketched
await kclManager.executeAstMock(modifiedAst)
const didReParse = await kclManager.executeAstMock(modifiedAst)
if (err(didReParse)) {
// there was a problem, restore the original code
codeManager.code = originalCode
await kclManager.executeCode()
return reject(didReParse)
}
const id =
input.type === 'extrudeFace' ? input.faceId : input.planeId