ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't bail command palette if there's no engineConnection (#6286)

Browse Source 
The connection can't be bad if there is not yet `:galaxy-brain:`.

But seriously this behavior regressed share links because we would bail
from the command palette because the connection wasn't healthy.
This commit is contained in:
Frank Noirot
2025-04-11 14:24:56 -04:00
committed by GitHub
parent c0aa763c3b
commit 129b91518f
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/components/CommandBar/CommandBar.tsx
View File

@ -10,6 +10,7 @@ import Tooltip from '@src/components/Tooltip'
import { useNetworkContext } from '@src/hooks/useNetworkContext' import { useNetworkContext } from '@src/hooks/useNetworkContext'
import { EngineConnectionStateType } from '@src/lang/std/engineConnection' import { EngineConnectionStateType } from '@src/lang/std/engineConnection'
import useHotkeyWrapper from '@src/lib/hotkeyWrapper' import useHotkeyWrapper from '@src/lib/hotkeyWrapper'
import { engineCommandManager } from '@src/lib/singletons'
import { import {
commandBarActor, commandBarActor,
useCommandBarState, useCommandBarState,
@ -46,6 +47,7 @@ export const CommandBar = () => {
useEffect(() => { useEffect(() => {
if ( if (
!commandBarActor.getSnapshot().matches('Closed') && !commandBarActor.getSnapshot().matches('Closed') &&
engineCommandManager.engineConnection &&
(immediateState.type === EngineConnectionStateType.Disconnecting || (immediateState.type === EngineConnectionStateType.Disconnecting ||
immediateState.type === EngineConnectionStateType.Disconnected) immediateState.type === EngineConnectionStateType.Disconnected)
) { ) {