Fix lazy fillet (#3176)

* WIP: Fix lazy fillet

* cleanup

Signed-off-by: Jess Frazelle <github@jessfraz.com>

---------

Signed-off-by: Jess Frazelle <github@jessfraz.com>
Co-authored-by: Jess Frazelle <github@jessfraz.com>
Co-authored-by: Jess Frazelle <jessfraz@users.noreply.github.com>
This commit is contained in:
Jonathan Tran
2024-07-29 23:22:52 -04:00
committed by GitHub
parent 789fb83a5d
commit 1c44b01d16
9 changed files with 253 additions and 57 deletions

View File

@ -24,7 +24,7 @@ const plumbus1 =
|> extrude(plumbusLen, %)
|> fillet({
radius: 5,
tags: [c1.tags.arc_tag, getOppositeEdge(c1.tags.arc_tag)]
tags: [c1.tags.arc_tag]
}, %)
const c2 = circl(200, a)
const plumbus0 =
@ -32,7 +32,7 @@ const plumbus0 =
|> extrude(plumbusLen, %)
|> fillet({
radius: 5,
tags: [c2.tags.arc_tag, getOppositeEdge(c2.tags.arc_tag)]
tags: [c2.tags.arc_tag]
}, %)

View File

@ -97,7 +97,6 @@ async fn serial_test_pipe_as_arg() {
}
#[tokio::test(flavor = "multi_thread")]
#[ignore] // We need to figure out why this broke even using scoped tags isn't working.
async fn serial_test_pentagon_fillet_sugar() {
let code = include_str!("inputs/pentagon_fillet_sugar.kcl");
let result = execute_and_snapshot(code, UnitLength::Cm).await.unwrap();
@ -1701,7 +1700,6 @@ const part002 = startSketchOn(part001, 'end')
}
#[tokio::test(flavor = "multi_thread")]
#[ignore] // We need to figure out why this broke even using scoped tags isn't working.
async fn serial_test_plumbus_fillets() {
let code = r#"fn make_circle = (ext, face, pos, radius) => {
const sg = startSketchOn(ext, face)
@ -1748,7 +1746,7 @@ const plumbus0 = circle0
|> extrude(10, %)
|> fillet({
radius: 0.5,
tags: [circle0.tags.arc1, getOppositeEdge(circle0.tags.arc1)]
tags: [circle0.tags.arc1]
}, %)
const circle1 = make_circle(p, p.sketchGroup.tags.b, [0, 0], 2.5)
@ -1756,7 +1754,7 @@ const plumbus1 = circle1
|> extrude(10, %)
|> fillet({
radius: 0.5,
tags: [circle1.tags.arc1, getOppositeEdge(circle1.tags.arc1)]
tags: [circle1.tags.arc1]
}, %)
"#;

Binary file not shown.

Before

Width:  |  Height:  |  Size: 95 KiB

After

Width:  |  Height:  |  Size: 95 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 132 KiB

After

Width:  |  Height:  |  Size: 131 KiB