Use better names for engine/KCL tests (#3193)

'serial_test' isn't actually accurate. Two of these tests run in parallel
now. So I renamed it 'kcl_test' as that's what it's actually doing.

In the nextest config, I changed the label from 'serial-integration' to
'uses-engine' because the former isn't true, and also doesn't explain
_why_ it's being limited. The new name explains why we're limiting the
number of tests that can run in parallel.
This commit is contained in:
Adam Chalmers
2024-07-30 16:12:01 -05:00
committed by GitHub
parent f34c23d203
commit 1e07ea4986
4 changed files with 141 additions and 141 deletions

6
src-tauri/Cargo.lock generated
View File

@ -2571,7 +2571,7 @@ dependencies = [
[[package]] [[package]]
name = "kcl-lib" name = "kcl-lib"
version = "0.2.2" version = "0.2.3"
dependencies = [ dependencies = [
"anyhow", "anyhow",
"approx", "approx",
@ -3520,9 +3520,9 @@ dependencies = [
[[package]] [[package]]
name = "phonenumber" name = "phonenumber"
version = "0.3.5+8.13.36" version = "0.3.6+8.13.36"
source = "registry+https://github.com/rust-lang/crates.io-index" source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "f174c8db59b620032bd52b655fc97000458850fec0db35fcd4e802b668517ec0" checksum = "11756237b57b8cc5e97dc8b1e70ea436324d30e7075de63b14fd15073a8f692a"
dependencies = [ dependencies = [
"bincode", "bincode",
"either", "either",

View File

@ -1,9 +1,7 @@
# Each test can have at most 4 threads, but if its name contains "serial_test_", then it
# also requires 4 threads.
# This means such tests run one at a time, with 4 threads.
[test-groups] [test-groups]
serial-integration = { max-threads = 4 } # If a test uses the engine, we want to limit the number that can run in parallel.
# This way we don't start and stop too many engine instances, putting pressure on our cloud.
uses-engine = { max-threads = 4 }
[profile.default] [profile.default]
slow-timeout = { period = "30s", terminate-after = 1 } slow-timeout = { period = "30s", terminate-after = 1 }
@ -12,13 +10,15 @@ slow-timeout = { period = "30s", terminate-after = 1 }
slow-timeout = { period = "50s", terminate-after = 5 } slow-timeout = { period = "50s", terminate-after = 5 }
[[profile.default.overrides]] [[profile.default.overrides]]
filter = "test(serial_test_)" # If a test starts with kcl_test_, then it uses the engine. So, limit its parallelism.
test-group = "serial-integration" filter = "test(kcl_test_)"
test-group = "uses-engine"
threads-required = 2 threads-required = 2
[[profile.ci.overrides]] [[profile.ci.overrides]]
filter = "test(serial_test_)" # If a test starts with kcl_test_, then it uses the engine. So, limit its parallelism.
test-group = "serial-integration" filter = "test(kcl_test_)"
test-group = "uses-engine"
threads-required = 2 threads-required = 2
[[profile.default.overrides]] [[profile.default.overrides]]

View File

@ -1851,7 +1851,7 @@ dependencies = [
"bincode", "bincode",
"either", "either",
"fnv", "fnv",
"itertools 0.12.1", "itertools 0.10.5",
"lazy_static", "lazy_static",
"nom", "nom",
"quick-xml", "quick-xml",

File diff suppressed because it is too large Load Diff