ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

use face edge info for some mirrors (#7174)

Browse Source 
* use face edge info for some mirrors

* add functionality for other mirror function

* Fix to create new Sketch when mirror results in a new path

* use the original ids and clone the sketches

* remove mirror param

* clippy fix

* debuggin, rm yarn

* Revert "remove mirror param"

This reverts commit a848e243f8.

* use arrbitrary edge_id as sketch mirror id

* additinoal clenaup

* Update rust/kcl-lib/src/std/mirror.rs

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

* set .mirror for continuous case

* fix warning

* works without the for loops

* add error handling

* remove duplicate setter

* rm unused var

* clenaup

* unused import

* remove unused let

* Update snapshots

* Update snapshots

* cleanup

* update sim tests

---------

Co-authored-by: gserena <serena@zoo.dev>
Co-authored-by: Jonathan Tran <jonnytran@gmail.com>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This commit is contained in:
Serena Gandhi
2025-06-23 12:27:03 -05:00
committed by GitHub
parent 631b63b1b6
commit 1e1bdbd6e7
13 changed files with 67 additions and 175 deletions
Download Patch File Download Diff File Expand all files Collapse all files

BIN
rust/kcl-lib/tests/kcl_samples/ball-joint-rod-end/rendered_model.png
View File

Binary file not shown.
Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 83 KiB

After

Width:  |  Height:  |  Size: 83 KiB

8
rust/kcl-lib/tests/kcl_samples/bottle/artifact_commands.snap
View File

@ -148,14 +148,6 @@ description: Artifact commands bottle.kcl
}
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "entity_get_all_child_uuids",
"entity_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],

8
rust/kcl-lib/tests/kcl_samples/cold-plate/artifact_commands.snap
View File

@ -327,14 +327,6 @@ description: Artifact commands cold-plate.kcl
}
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "entity_get_all_child_uuids",
"entity_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],

32
rust/kcl-lib/tests/kcl_samples/cpu-cooler/artifact_commands.snap
View File

@ -4828,14 +4828,6 @@ description: Artifact commands cpu-cooler.kcl
}
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "entity_get_all_child_uuids",
"entity_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
@ -4856,14 +4848,6 @@ description: Artifact commands cpu-cooler.kcl
}
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "entity_get_all_child_uuids",
"entity_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
@ -6095,14 +6079,6 @@ description: Artifact commands cpu-cooler.kcl
}
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "entity_get_all_child_uuids",
"entity_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
@ -6436,14 +6412,6 @@ description: Artifact commands cpu-cooler.kcl
}
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "entity_get_all_child_uuids",
"entity_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],

16
rust/kcl-lib/tests/kcl_samples/helium-tank/artifact_commands.snap
View File

@ -1136,14 +1136,6 @@ description: Artifact commands helium-tank.kcl
}
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "entity_get_all_child_uuids",
"entity_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
@ -1362,14 +1354,6 @@ description: Artifact commands helium-tank.kcl
}
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "entity_get_all_child_uuids",
"entity_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],

16
rust/kcl-lib/tests/kcl_samples/i-beam/artifact_commands.snap
View File

@ -176,14 +176,6 @@ description: Artifact commands i-beam.kcl
}
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "entity_get_all_child_uuids",
"entity_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
@ -204,14 +196,6 @@ description: Artifact commands i-beam.kcl
}
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "entity_get_all_child_uuids",
"entity_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],

24
rust/kcl-lib/tests/kcl_samples/t-slot-rail/artifact_commands.snap
View File

@ -342,14 +342,6 @@ description: Artifact commands t-slot-rail.kcl
}
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "entity_get_all_child_uuids",
"entity_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
@ -370,14 +362,6 @@ description: Artifact commands t-slot-rail.kcl
}
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "entity_get_all_child_uuids",
"entity_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
@ -398,14 +382,6 @@ description: Artifact commands t-slot-rail.kcl
}
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "entity_get_all_child_uuids",
"entity_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],

24
rust/kcl-lib/tests/subtract_regression10/artifact_commands.snap
View File

@ -1170,14 +1170,6 @@ description: Artifact commands subtract_regression10.kcl
}
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "entity_get_all_child_uuids",
"entity_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
@ -1639,14 +1631,6 @@ description: Artifact commands subtract_regression10.kcl
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "entity_get_all_child_uuids",
"entity_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
@ -1895,14 +1879,6 @@ description: Artifact commands subtract_regression10.kcl
}
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "entity_get_all_child_uuids",
"entity_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],