ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

change to no longer parallel for edges (#6705)

Browse Source 
Signed-off-by: Jess Frazelle <github@jessfraz.com>
This commit is contained in:
Jess Frazelle
2025-05-05 18:06:20 -07:00
committed by GitHub
parent 8f72920764
commit 1ed6bb8a7c
12 changed files with 23 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files

82
rust/kcl-lib/src/std/extrude.rs
View File

@ -337,18 +337,6 @@ pub(crate) async fn do_post_extrude<'a>(
let next_adjacent_edge_uuid = exec_state.next_uuid();
let get_all_edge_faces_opposite_uuid = exec_state.next_uuid();
let get_all_edge_faces_next_uuid = exec_state.next_uuid();
#[cfg(any(not(test), not(feature = "artifact-graph"), not(target_arch = "wasm32")))]
#[allow(unused_variables)]
let single_threaded = false;
// When running in vitest, we need to run this in a single thread.
// Because their workers are complete shit.
#[cfg(target_arch = "wasm32")]
let single_threaded = crate::wasm::vitest::running_in_vitest();
// If we are running in a test, for the arifact graph to be deterministic and not fail
// after say a fillet runs concurrently, we need to make sure that the
// async tasks are done before we return.
#[cfg(all(test, feature = "artifact-graph", not(target_arch = "wasm32")))]
let single_threaded = true;
// Get faces for original edge
// Since this one is batched we can just run it.
@ -361,57 +349,27 @@ pub(crate) async fn do_post_extrude<'a>(
)
.await?;
if !single_threaded {
args.ctx
.engine
.async_tasks()
.spawn(get_bg_edge_info_opposite(
args_cloned.clone(),
curve_id,
sketch.id,
face_id,
opposite_edge_uuid,
get_all_edge_faces_opposite_uuid,
single_threaded,
))
.await;
get_bg_edge_info_opposite(
args_cloned.clone(),
curve_id,
sketch.id,
face_id,
opposite_edge_uuid,
get_all_edge_faces_opposite_uuid,
true,
)
.await?;
args.ctx
.engine
.async_tasks()
.spawn(get_bg_edge_info_next(
args_cloned,
curve_id,
sketch.id,
face_id,
next_adjacent_edge_uuid,
get_all_edge_faces_next_uuid,
single_threaded,
))
.await;
} else {
get_bg_edge_info_opposite(
args_cloned.clone(),
curve_id,
sketch.id,
face_id,
opposite_edge_uuid,
get_all_edge_faces_opposite_uuid,
single_threaded,
)
.await?;
get_bg_edge_info_next(
args_cloned,
curve_id,
sketch.id,
face_id,
next_adjacent_edge_uuid,
get_all_edge_faces_next_uuid,
single_threaded,
)
.await?;
}
get_bg_edge_info_next(
args_cloned,
curve_id,
sketch.id,
face_id,
next_adjacent_edge_uuid,
get_all_edge_faces_next_uuid,
true,
)
.await?;
}
let Faces {