internal: Add lints for promises (#3733)

* Add lints for floating and misued promises

* Add logging async errors in main

* Add async error catch in test-utils

* Change any to unknown

* Trap promise errors and ignore more await warnings

* Add more ignores and toSync helper

* Fix more lint warnings

* Add more ignores and fixes

* Add more reject reporting

* Add accepting arbitrary parameters to toSync()

* Fix more lints

* Revert unintentional change to non-arrow function

* Revert unintentional change to use arrow function

* Fix new warnings in main with auto updater

* Fix formatting

* Change lints to error

This is what the recommended type checked rules do.

* Fix to properly report promise rejections

* Fix formatting

* Fix formatting

* Remove unused import

* Remove unused convenience function

* Move type helpers

* Fix to not return promise when caller doesn't expect it

* Add ignores to lsp code

src/lib/testHelpers.ts

@@ -7,7 +7,8 @@ import { EngineCommand } from 'lang/std/artifactGraph'
 import { Models } from '@kittycad/lib'
 import { v4 as uuidv4 } from 'uuid'
 import { DefaultPlanes } from 'wasm-lib/kcl/bindings/DefaultPlanes'
-import { err } from 'lib/trap'
+import { err, reportRejection } from 'lib/trap'
+import { toSync } from './utils'
 
 type WebSocketResponse = Models['WebSocketResponse_type']
 
@@ -85,6 +86,7 @@ export async function enginelessExecutor(
     setIsStreamReady: () => {},
     setMediaStream: () => {},
   }) as any as EngineCommandManager
+  // eslint-disable-next-line @typescript-eslint/no-floating-promises
   mockEngineCommandManager.startNewSession()
   const programMemory = await _executor(ast, pm, mockEngineCommandManager, true)
   await mockEngineCommandManager.waitForAllCommands()
@@ -112,7 +114,8 @@ export async function executor(
   return new Promise((resolve) => {
     engineCommandManager.addEventListener(
       EngineCommandManagerEvents.SceneReady,
-      async () => {
+      toSync(async () => {
+        // eslint-disable-next-line @typescript-eslint/no-floating-promises
         engineCommandManager.startNewSession()
         const programMemory = await _executor(
           ast,
@@ -121,8 +124,8 @@ export async function executor(
           false
         )
         await engineCommandManager.waitForAllCommands()
-        Promise.resolve(programMemory)
-      }
+        resolve(programMemory)
+      }, reportRejection)
     )
   })
 }