ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fire off "Cancel" modelingMachine event before unmount (#2520)

Browse Source 
Co-authored-by: Jess Frazelle <jessfraz@users.noreply.github.com>
This commit is contained in:
Frank Noirot
2024-05-24 16:01:16 -04:00
committed by GitHub
parent dc6505acaf
commit 27e2518dde
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/components/ModelingMachineProvider.tsx
View File

@ -637,6 +637,12 @@ export const ModelingMachineProvider = ({
kclManager.registerExecuteCallback(() => { kclManager.registerExecuteCallback(() => {
modelingSend({ type: 'Re-execute' }) modelingSend({ type: 'Re-execute' })
}) })
// Before this component unmounts, call the 'Cancel'
// event to clean up any state in the modeling machine.
return () => {
modelingSend({ type: 'Cancel' })
}
}, [modelingSend]) }, [modelingSend])
// Give the state back to the editorManager. // Give the state back to the editorManager.
@ -659,6 +665,10 @@ export const ModelingMachineProvider = ({
actor: modelingActor, actor: modelingActor,
commandBarConfig: modelingMachineConfig, commandBarConfig: modelingMachineConfig,
allCommandsRequireNetwork: true, allCommandsRequireNetwork: true,
// TODO for when sketch tools are in the toolbar: This was added when we used one "Cancel" event,
// but we need to support "SketchCancel" and basically
// make this function take the actor or state so it
// can call the correct event.
onCancel: () => modelingSend({ type: 'Cancel' }), onCancel: () => modelingSend({ type: 'Cancel' }),
}) })