Fix test: traverse was not handling CallExpressionKw
This commit is contained in:
committed by
Nick Cameron
parent
ae0860a775
commit
2943ea1fd6
@ -141,14 +141,14 @@ yo2 = hmm([identifierGuy + 5])`
|
|||||||
})
|
})
|
||||||
it('find an UNsafe Identifier, as it is a callee', () => {
|
it('find an UNsafe Identifier, as it is a callee', () => {
|
||||||
const ast = assertParse(code)
|
const ast = assertParse(code)
|
||||||
const rangeStart = code.indexOf('ine([2.8,')
|
const rangeStart = code.indexOf('ine(end = [2.8,')
|
||||||
const result = isNodeSafeToReplace(
|
const result = isNodeSafeToReplace(
|
||||||
ast,
|
ast,
|
||||||
topLevelRange(rangeStart, rangeStart)
|
topLevelRange(rangeStart, rangeStart)
|
||||||
)
|
)
|
||||||
if (err(result)) throw result
|
if (err(result)) throw result
|
||||||
expect(result.isSafe).toBe(false)
|
expect(result.isSafe).toBe(false)
|
||||||
expect(result.value?.type).toBe('CallExpression')
|
expect(result.value?.type).toBe('CallExpressionKw')
|
||||||
expect(code.slice(result.value.start, result.value.end)).toBe(
|
expect(code.slice(result.value.start, result.value.end)).toBe(
|
||||||
'line(end = [2.8, 0])'
|
'line(end = [2.8, 0])'
|
||||||
)
|
)
|
||||||
|
@ -478,6 +478,22 @@ export function traverse(
|
|||||||
[index, 'index'],
|
[index, 'index'],
|
||||||
])
|
])
|
||||||
)
|
)
|
||||||
|
} else if (_node.type === 'CallExpressionKw') {
|
||||||
|
_traverse(_node.callee, [...pathToNode, ['callee', 'CallExpressionKw']])
|
||||||
|
if (_node.unlabeled !== null) {
|
||||||
|
_traverse(_node.unlabeled, [
|
||||||
|
...pathToNode,
|
||||||
|
['unlabeled', 'Unlabeled arg'],
|
||||||
|
])
|
||||||
|
}
|
||||||
|
_node.arguments.forEach((arg, index) =>
|
||||||
|
_traverse(arg.arg, [
|
||||||
|
...pathToNode,
|
||||||
|
['arguments', 'CallExpressionKw'],
|
||||||
|
[index, 'arg index'],
|
||||||
|
['arg', 'LabeledArg -> Arg'],
|
||||||
|
])
|
||||||
|
)
|
||||||
} else if (_node.type === 'BinaryExpression') {
|
} else if (_node.type === 'BinaryExpression') {
|
||||||
_traverse(_node.left, [...pathToNode, ['left', 'BinaryExpression']])
|
_traverse(_node.left, [...pathToNode, ['left', 'BinaryExpression']])
|
||||||
_traverse(_node.right, [...pathToNode, ['right', 'BinaryExpression']])
|
_traverse(_node.right, [...pathToNode, ['right', 'BinaryExpression']])
|
||||||
|
Reference in New Issue
Block a user