* add test for rect panning bug * tweak timeouts * cleanups, handle both center and corner rectangle * revert regression that was used for the test * apply PR feedback
This commit is contained in:
@ -1216,4 +1216,55 @@ sketch001 = startSketchOn(XZ)
|
|||||||
})
|
})
|
||||||
}
|
}
|
||||||
)
|
)
|
||||||
|
|
||||||
|
test('Rectangle tool panning with middle click', async ({
|
||||||
|
page,
|
||||||
|
homePage,
|
||||||
|
toolbar,
|
||||||
|
scene,
|
||||||
|
cmdBar,
|
||||||
|
editor,
|
||||||
|
}) => {
|
||||||
|
await page.setBodyDimensions({ width: 1200, height: 900 })
|
||||||
|
await homePage.goToModelingScene()
|
||||||
|
|
||||||
|
// wait until scene is ready to be interacted with
|
||||||
|
await scene.connectionEstablished()
|
||||||
|
await scene.settled(cmdBar)
|
||||||
|
|
||||||
|
await page.getByRole('button', { name: 'Start Sketch' }).click()
|
||||||
|
|
||||||
|
// select an axis plane
|
||||||
|
await page.mouse.click(700, 200)
|
||||||
|
|
||||||
|
// Needed as we don't yet have a way to get a signal from the engine that the camera has animated to the sketch plane
|
||||||
|
await page.waitForTimeout(1000)
|
||||||
|
|
||||||
|
const middleMousePan = async (
|
||||||
|
startX: number,
|
||||||
|
startY: number,
|
||||||
|
endX: number,
|
||||||
|
endY: number
|
||||||
|
) => {
|
||||||
|
const initialCode = await editor.getCurrentCode()
|
||||||
|
|
||||||
|
await page.mouse.click(startX, startY, { button: 'middle' })
|
||||||
|
await page.mouse.move(endX, endY, {
|
||||||
|
steps: 10,
|
||||||
|
})
|
||||||
|
|
||||||
|
// We expect the code to be the same, middle mouse click should not modify the code, only do panning
|
||||||
|
await editor.expectEditor.toBe(initialCode)
|
||||||
|
}
|
||||||
|
|
||||||
|
await test.step(`Verify corner rectangle panning`, async () => {
|
||||||
|
await page.getByTestId('corner-rectangle').click()
|
||||||
|
await middleMousePan(800, 500, 900, 600)
|
||||||
|
})
|
||||||
|
|
||||||
|
await test.step(`Verify center rectangle panning`, async () => {
|
||||||
|
await toolbar.selectCenterRectangle()
|
||||||
|
await middleMousePan(800, 200, 900, 300)
|
||||||
|
})
|
||||||
|
})
|
||||||
})
|
})
|
||||||
|
@ -81,6 +81,13 @@ export class EditorFixture {
|
|||||||
expectEditor = {
|
expectEditor = {
|
||||||
toContain: this._expectEditorToContain(),
|
toContain: this._expectEditorToContain(),
|
||||||
not: { toContain: this._expectEditorToContain(true) },
|
not: { toContain: this._expectEditorToContain(true) },
|
||||||
|
toBe: async (code: string) => {
|
||||||
|
const currentCode = await this.getCurrentCode()
|
||||||
|
return expect(currentCode).toBe(code)
|
||||||
|
},
|
||||||
|
}
|
||||||
|
getCurrentCode = async () => {
|
||||||
|
return await this.codeContent.innerText()
|
||||||
}
|
}
|
||||||
snapshot = async (options?: { timeout?: number; name?: string }) => {
|
snapshot = async (options?: { timeout?: number; name?: string }) => {
|
||||||
const wasPaneOpen = await this.checkIfPaneIsOpen()
|
const wasPaneOpen = await this.checkIfPaneIsOpen()
|
||||||
|
Reference in New Issue
Block a user