ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

WIP selections

Browse Source
This commit is contained in:
Pierre Jacquier
2024-11-29 12:37:53 -05:00
parent a7d3552472
commit 31cbc90f56
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/components/ModelingMachineProvider.tsx
View File

@ -589,8 +589,6 @@ export const ModelingMachineProvider = ({
'isSketchPipe(selectionRanges)', 'isSketchPipe(selectionRanges)',
isSketchPipe(selectionRanges) isSketchPipe(selectionRanges)
) )
// TODO: The way this is isn't letting me loft
// if (!isSketchPipe(selectionRanges)) return false
const canLoft = canLoftSelection(selectionRanges) const canLoft = canLoftSelection(selectionRanges)
if (err(canLoft)) return false if (err(canLoft)) return false

6
src/lib/selections.ts
View File

@ -567,9 +567,11 @@ export function canLoftSelection(selection: Selections) {
console.log('commonNodes', commonNodes) console.log('commonNodes', commonNodes)
console.log('isSketchPipe', isSketchPipe(selection)) console.log('isSketchPipe', isSketchPipe(selection))
return ( return (
// TODO: check if we need ifSketchPipe or other things enabled !!isCursorInSketchCommandRange(
// !!isSketchPipe(selection) && engineCommandManager.artifactGraph,
selection) &&
commonNodes.length > 1 && commonNodes.length > 1 &&
// TODO: check if needed
// commonNodes.every((n) => !hasSketchPipeBeenExtruded(n.selection, n.ast)) && // commonNodes.every((n) => !hasSketchPipeBeenExtruded(n.selection, n.ast)) &&
commonNodes.every((n) => nodeHasClose(n) || nodeHasCircle(n)) && commonNodes.every((n) => nodeHasClose(n) || nodeHasCircle(n)) &&
commonNodes.every((n) => !nodeHasExtrude(n)) commonNodes.every((n) => !nodeHasExtrude(n))