ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix .length on undefined WASM error (#6048)

Browse Source
This commit is contained in:
Jonathan Tran
2025-03-28 14:48:47 -04:00
committed by GitHub
parent 42123383bb
commit 36875e05fd
2 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
e2e/playwright/lib/console-error-whitelist.ts
View File

@ -258,14 +258,6 @@ export const isErrorWhitelisted = (exception: Error) => {
foundInSpec: 'e2e/playwright/testing-settings.spec.ts', foundInSpec: 'e2e/playwright/testing-settings.spec.ts',
}, },
// TODO: fix this error in the code // TODO: fix this error in the code
{
name: 'TypeError',
message: "Cannot read properties of undefined (reading 'length')",
stack: '',
project: 'Google Chrome',
foundInSpec: '', // many tests are impacted by this error
},
// TODO: fix this error in the code
{ {
name: 'ReferenceError', name: 'ReferenceError',
message: '_testUtils is not defined', message: '_testUtils is not defined',

7
rust/kcl-lib/src/engine/conn_wasm.rs
View File

@ -121,6 +121,13 @@ impl EngineConnection {
} }
})?; })?;
if value.is_null() || value.is_undefined() {
return Err(KclError::Engine(KclErrorDetails {
message: "Received null or undefined response from engine".into(),
source_ranges: vec![source_range],
}));
}
// Convert JsValue to a Uint8Array // Convert JsValue to a Uint8Array
let data = js_sys::Uint8Array::from(value); let data = js_sys::Uint8Array::from(value);