[refactor] remove 6 floating-promise ignores (#5985)
* Remove trivial floating promise in authMachine * Add catch statement so LSP promise is considered non-floating * Remove trivial float in AllSettingsFields * Add error reporting for ensureWasmInit * Remove pointless floating promise in Modeling * Add comment and reportRejection to floating promise in "set selection" * Read comment, put back await that should be there * Fix dumb imports rebase botch * Missed an import --------- Co-authored-by: Jess Frazelle <jessfraz@users.noreply.github.com>
This commit is contained in:
@ -445,10 +445,15 @@ export const ModelingMachineProvider = ({
|
||||
},
|
||||
})
|
||||
}
|
||||
|
||||
// If there are engine commands that need sent off, send them
|
||||
// TODO: This should be handled outside of an action as its own
|
||||
// actor, so that the system state is more controlled.
|
||||
engineEvents &&
|
||||
engineEvents.forEach((event) => {
|
||||
// eslint-disable-next-line @typescript-eslint/no-floating-promises
|
||||
engineCommandManager.sendSceneCommand(event)
|
||||
engineCommandManager
|
||||
.sendSceneCommand(event)
|
||||
.catch(reportRejection)
|
||||
})
|
||||
updateSceneObjectColors()
|
||||
|
||||
@ -1566,9 +1571,7 @@ export const ModelingMachineProvider = ({
|
||||
data
|
||||
)
|
||||
if (err(result)) return reject(result)
|
||||
|
||||
// eslint-disable-next-line @typescript-eslint/no-floating-promises
|
||||
codeManager.updateEditorWithAstAndWriteToFile(kclManager.ast)
|
||||
await codeManager.updateEditorWithAstAndWriteToFile(kclManager.ast)
|
||||
|
||||
return result
|
||||
}
|
||||
|
Reference in New Issue
Block a user