From 3ed263da6bafdff7a44e3943e8c77bc5589e8eeb Mon Sep 17 00:00:00 2001
From: Adam Chalmers <adam.chalmers@kittycad.io>
Date: Mon, 22 Jan 2024 10:45:48 +1100
Subject: [PATCH] Grackle: Tests for computed properties (#1303)

These tests don't pass, because Grackle doesn't support computed properties yet. But they're worth committing anyway, so I put "#[ignore]" on them.
---
 src/wasm-lib/grackle/src/lib.rs   |  5 ++--
 src/wasm-lib/grackle/src/tests.rs | 40 ++++++++++++++++++++++++++++++-
 2 files changed, 42 insertions(+), 3 deletions(-)

diff --git a/src/wasm-lib/grackle/src/lib.rs b/src/wasm-lib/grackle/src/lib.rs
index 57d400d89..13a87245c 100644
--- a/src/wasm-lib/grackle/src/lib.rs
+++ b/src/wasm-lib/grackle/src/lib.rs
@@ -197,9 +197,10 @@ impl Planner {
                 let mut binding = self.binding_scope.get(&name).ok_or(CompileError::Undefined { name })?;
                 for (property, computed) in properties {
                     if computed {
-                        todo!("Support computed properties");
+                        todo!("Support computed properties like '{:?}'", property);
+                    } else {
+                        binding = binding.property_of(property)?;
                     }
-                    binding = binding.property_of(property)?;
                 }
                 Ok(EvalPlan {
                     instructions: Vec::new(),
diff --git a/src/wasm-lib/grackle/src/tests.rs b/src/wasm-lib/grackle/src/tests.rs
index 444c4bcfe..2116b49c9 100644
--- a/src/wasm-lib/grackle/src/tests.rs
+++ b/src/wasm-lib/grackle/src/tests.rs
@@ -171,6 +171,44 @@ fn use_native_function_id() {
     );
 }
 
+#[test]
+#[ignore = "haven't done computed properties yet"]
+fn computed_array_index() {
+    let program = r#"
+    let array = ["a", "b", "c"]
+    let index = 1+1
+    let prop = array[index]
+    "#;
+    let (_plan, scope) = must_plan(program);
+    match scope.get("prop").unwrap() {
+        EpBinding::Single(addr) => {
+            assert_eq!(*addr, Address::ZERO + 1);
+        }
+        other => {
+            panic!("expected 'prop' bound to 0x0 but it was bound to {other:?}");
+        }
+    }
+}
+
+#[test]
+#[ignore = "haven't done computed properties yet"]
+fn computed_member_expressions() {
+    let program = r#"
+    let obj = {x: 1, y: 2}
+    let index = "x"
+    let prop = obj[index]
+    "#;
+    let (_plan, scope) = must_plan(program);
+    match scope.get("prop").unwrap() {
+        EpBinding::Single(addr) => {
+            assert_eq!(*addr, Address::ZERO + 1);
+        }
+        other => {
+            panic!("expected 'prop' bound to 0x0 but it was bound to {other:?}");
+        }
+    }
+}
+
 #[test]
 fn member_expressions_object() {
     let program = r#"
@@ -183,7 +221,7 @@ fn member_expressions_object() {
             assert_eq!(*addr, Address::ZERO + 1);
         }
         other => {
-            panic!("expected 'number' bound to 0x0 but it was bound to {other:?}");
+            panic!("expected 'prop' bound to 0x0 but it was bound to {other:?}");
         }
     }
 }