Comment out Vector, add back removed camera test code

.github/workflows/e2e-tests.yml

@@ -99,22 +99,22 @@ jobs:
       run: |
         brew install gnu-sed
         echo "/opt/homebrew/opt/gnu-sed/libexec/gnubin" >> $GITHUB_PATH
-    - name: Install vector
-      shell: bash
-      if:  ${{ !startsWith(matrix.os, 'windows') }}
-      run: |
-        curl --proto '=https' --tlsv1.2 -sSfL https://sh.vector.dev > /tmp/vector.sh
-        chmod +x /tmp/vector.sh
-        /tmp/vector.sh -y -no-modify-path
-        mkdir -p /tmp/vector
-        cp .github/workflows/vector.toml /tmp/vector.toml
-        sed -i "s#GITHUB_WORKFLOW#${GITHUB_WORKFLOW}#g" /tmp/vector.toml
-        sed -i "s#GITHUB_REPOSITORY#${GITHUB_REPOSITORY}#g" /tmp/vector.toml
-        sed -i "s#GITHUB_SHA#${GITHUB_SHA}#g" /tmp/vector.toml
-        sed -i "s#GITHUB_REF_NAME#${GITHUB_REF_NAME}#g" /tmp/vector.toml
-        sed -i "s#GH_ACTIONS_AXIOM_TOKEN#${{secrets.GH_ACTIONS_AXIOM_TOKEN}}#g" /tmp/vector.toml
-        cat /tmp/vector.toml
-        ${HOME}/.vector/bin/vector --config /tmp/vector.toml &
+#    - name: Install vector
+#      shell: bash
+#      if:  ${{ !startsWith(matrix.os, 'windows') }}
+#      run: |
+#        curl --proto '=https' --tlsv1.2 -sSfL https://sh.vector.dev > /tmp/vector.sh
+#        chmod +x /tmp/vector.sh
+#        /tmp/vector.sh -y -no-modify-path
+#        mkdir -p /tmp/vector
+#        cp .github/workflows/vector.toml /tmp/vector.toml
+#        sed -i "s#GITHUB_WORKFLOW#${GITHUB_WORKFLOW}#g" /tmp/vector.toml
+#        sed -i "s#GITHUB_REPOSITORY#${GITHUB_REPOSITORY}#g" /tmp/vector.toml
+#        sed -i "s#GITHUB_SHA#${GITHUB_SHA}#g" /tmp/vector.toml
+#        sed -i "s#GITHUB_REF_NAME#${GITHUB_REF_NAME}#g" /tmp/vector.toml
+#        sed -i "s#GH_ACTIONS_AXIOM_TOKEN#${{secrets.GH_ACTIONS_AXIOM_TOKEN}}#g" /tmp/vector.toml
+#        cat /tmp/vector.toml
+#        ${HOME}/.vector/bin/vector --config /tmp/vector.toml &
     - name: Build Wasm (because rust diff)
       if: needs.check-rust-changes.outputs.rust-changed == 'true'
       shell: bash

e2e/playwright/editor-tests.spec.ts

@@ -54,7 +54,10 @@ test.describe('Editor tests', () => {
   |> close(%)`)
   })
 
-  test('ensure we use the cache, and do not re-execute', async ({ homePage, page }) => {
+  test('ensure we use the cache, and do not re-execute', async ({
+    homePage,
+    page,
+  }) => {
     const u = await getUtils(page)
     await page.setBodyDimensions({ width: 1000, height: 500 })
 

e2e/playwright/testing-camera-movement.spec.ts

@@ -408,8 +408,7 @@ test.describe('Testing Camera Movement', () => {
         await u.waitForCmdReceive('default_camera_get_settings')
       })
 
-      await expect
-        .poll(getCameraZValue, {
+      await expect.poll(getCameraZValue, {
         message: 'Camera should be at expected position after zooming',
       })
       await callback()
@@ -426,10 +425,62 @@ test.describe('Testing Camera Movement', () => {
         .toEqual(expectedOrbitCamZPosition)
       await page.mouse.up({ button: 'middle' })
     })
+
+    // Helper functions
+    async function resetCamera() {
+      await test.step(`Reset camera`, async () => {
+        await u.openDebugPanel()
+        await u.clearCommandLogs()
+        await u.doAndWaitForCmd(async () => {
+          await gizmo.click({ button: 'right' })
+          await resetCameraButton.click()
+        }, 'zoom_to_fit')
+        await expect
+          .poll(getCameraZValue, {
+            message: 'Camera Z should be at expected position after reset',
+          })
+          .toEqual(expectedStartCamZPosition)
+      })
     }
+
+    async function getCameraZValue() {
+      return page
+        .getByTestId('cam-z-position')
+        .inputValue()
+        .then((value) => parseFloat(value))
+    }
+
+    async function doOrbitWith(callback = async () => {}) {
+      await resetCamera()
+
+      await test.step(`Perform orbit`, async () => {
+        await page.mouse.move(orbitMouseStart.x, orbitMouseStart.y)
+        await page.mouse.down({ button: 'middle' })
+        await page.mouse.move(orbitMouseStepOne.x, orbitMouseStepOne.y, {
+          steps: 3,
+        })
+        await callback()
+        await page.mouse.move(orbitMouseEnd.x, orbitMouseEnd.y, {
+          steps: 3,
+        })
       })
 
-  test('Right-click opens context menu when not dragged', async ({ homePage, page }) => {
+      await test.step(`Verify orbit`, async () => {
+        await expect
+          .poll(getCameraZValue, {
+            message: 'Camera should be at expected position after orbiting',
+          })
+          .toEqual(expectedOrbitCamZPosition)
+        await page.mouse.up({ button: 'middle' })
+      })
+    }
+
+  })
+
+  test('Right-click opens context menu when not dragged', async ({
+    homePage,
+    page,
+  }) => {
     const u = await getUtils(page)
     await homePage.goToModelingScene()
     await u.waitForPageLoad()