start of cache: don't re-execute on whitespace / top level code comment changes (#4663)

* start Signed-off-by: Jess Frazelle <github@jessfraz.com> working for whitespace Signed-off-by: Jess Frazelle <github@jessfraz.com> pull thru Signed-off-by: Jess Frazelle <github@jessfraz.com> fix wasm Signed-off-by: Jess Frazelle <github@jessfraz.com> pull thru to js start Signed-off-by: Jess Frazelle <github@jessfraz.com> actually use the cache in ts Signed-off-by: Jess Frazelle <github@jessfraz.com> rust owns clearing the scene Signed-off-by: Jess Frazelle <github@jessfraz.com> fixes Signed-off-by: Jess Frazelle <github@jessfraz.com> empty stupid log Signed-off-by: Jess Frazelle <github@jessfraz.com> updates Signed-off-by: Jess Frazelle <github@jessfraz.com> * updates Signed-off-by: Jess Frazelle <github@jessfraz.com> fix tests Signed-off-by: Jess Frazelle <github@jessfraz.com> updatez Signed-off-by: Jess Frazelle <github@jessfraz.com> updates Signed-off-by: Jess Frazelle <github@jessfraz.com> save the state Signed-off-by: Jess Frazelle <github@jessfraz.com> save the state Signed-off-by: Jess Frazelle <github@jessfraz.com> updates Signed-off-by: Jess Frazelle <github@jessfraz.com> use the old memory Signed-off-by: Jess Frazelle <github@jessfraz.com> cleanup to use the old exec state Signed-off-by: Jess Frazelle <github@jessfraz.com> fices Signed-off-by: Jess Frazelle <github@jessfraz.com> updates; Signed-off-by: Jess Frazelle <github@jessfraz.com> fixes Signed-off-by: Jess Frazelle <github@jessfraz.com> fmt Signed-off-by: Jess Frazelle <github@jessfraz.com> updates Signed-off-by: Jess Frazelle <github@jessfraz.com> fixes Signed-off-by: Jess Frazelle <github@jessfraz.com> updates Signed-off-by: Jess Frazelle <github@jessfraz.com> cleanup Signed-off-by: Jess Frazelle <github@jessfraz.com> fixes Signed-off-by: Jess Frazelle <github@jessfraz.com> * rebase and compile Signed-off-by: Jess Frazelle <github@jessfraz.com> * Look at this (photo)Graph *in the voice of Nickelback* * fix the lsp to use the cache Signed-off-by: Jess Frazelle <github@jessfraz.com> * add comment Signed-off-by: Jess Frazelle <github@jessfraz.com> * use a global static instead; Signed-off-by: Jess Frazelle <github@jessfraz.com> * fix rust test Signed-off-by: Jess Frazelle <github@jessfraz.com> * cleanup more Signed-off-by: Jess Frazelle <github@jessfraz.com> * cleanups Signed-off-by: Jess Frazelle <github@jessfraz.com> * cleanup the api even more Signed-off-by: Jess Frazelle <github@jessfraz.com> * updates Signed-off-by: Jess Frazelle <github@jessfraz.com> * updates Signed-off-by: Jess Frazelle <github@jessfraz.com> * Look at this (photo)Graph *in the voice of Nickelback* * bust the cache on unit changes Signed-off-by: Jess Frazelle <github@jessfraz.com> * updates Signed-off-by: Jess Frazelle <github@jessfraz.com> * updates Signed-off-by: Jess Frazelle <github@jessfraz.com> * updates Signed-off-by: Jess Frazelle <github@jessfraz.com> * Look at this (photo)Graph *in the voice of Nickelback* * stupid codespell Signed-off-by: Jess Frazelle <github@jessfraz.com> --------- Signed-off-by: Jess Frazelle <github@jessfraz.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2024-12-05 19:51:06 -08:00
parent 9e57034873
commit 441d957228
45 changed files with 741 additions and 189 deletions
--- a/src/lib/testHelpers.ts
+++ b/src/lib/testHelpers.ts
@ -4,7 +4,6 @@ import {
  _executor,
  SourceRange,
  ExecState,
-  defaultIdGenerator,
 } from '../lang/wasm'
 import {
  EngineCommandManager,
@ -16,7 +15,6 @@ import { v4 as uuidv4 } from 'uuid'
 import { DefaultPlanes } from 'wasm-lib/kcl/bindings/DefaultPlanes'
 import { err, reportRejection } from 'lib/trap'
 import { toSync } from './utils'
-import { IdGenerator } from 'wasm-lib/kcl/bindings/IdGenerator'
 import { Node } from 'wasm-lib/kcl/bindings/Node'

 type WebSocketResponse = Models['WebSocketResponse_type']
@ -86,10 +84,9 @@ class MockEngineCommandManager {

 export async function enginelessExecutor(
  ast: Node<Program>,
-  pm: ProgramMemory | Error = ProgramMemory.empty(),
-  idGenerator: IdGenerator = defaultIdGenerator()
+  pmo: ProgramMemory | Error = ProgramMemory.empty()
 ): Promise<ExecState> {
-  if (err(pm)) return Promise.reject(pm)
+  if (pmo !== null && err(pmo)) return Promise.reject(pmo)

  const mockEngineCommandManager = new MockEngineCommandManager({
    setIsStreamReady: () => {},
@ -97,21 +94,14 @@ export async function enginelessExecutor(
  }) as any as EngineCommandManager
  // eslint-disable-next-line @typescript-eslint/no-floating-promises
  mockEngineCommandManager.startNewSession()
-  const execState = await _executor(
-    ast,
-    pm,
-    idGenerator,
-    mockEngineCommandManager,
-    true
-  )
+  const execState = await _executor(ast, mockEngineCommandManager, pmo)
  await mockEngineCommandManager.waitForAllCommands()
  return execState
 }

 export async function executor(
  ast: Node<Program>,
-  pm: ProgramMemory = ProgramMemory.empty(),
-  idGenerator: IdGenerator = defaultIdGenerator()
+  pmo: ProgramMemory = ProgramMemory.empty()
 ): Promise<ExecState> {
  const engineCommandManager = new EngineCommandManager()
  engineCommandManager.start({
@ -133,13 +123,7 @@ export async function executor(
      toSync(async () => {
        // eslint-disable-next-line @typescript-eslint/no-floating-promises
        engineCommandManager.startNewSession()
-        const execState = await _executor(
-          ast,
-          pm,
-          idGenerator,
-          engineCommandManager,
-          false
-        )
+        const execState = await _executor(ast, engineCommandManager, pmo)
        await engineCommandManager.waitForAllCommands()
        resolve(execState)
      }, reportRejection)