KCL parser: Allow .prop or [index] to follow any expression (#7371)

Browse Source

Previously in a member expression like `foo.x` or `foo[3]`, `foo` had to be an identifier. You could not do something like `f().x` (and if you tried, you got a cryptic error). Rather than make the error better, we should just accept any expression to be the LHS of a member expression (aka its 'object').

This does knock our "parse lots of function calls" from 58 to 55 calls before it stack overflows. But I think it's fine, we'll address this in https://github.com/KittyCAD/modeling-app/pull/6226 when I get back to it.

Closes https://github.com/KittyCAD/modeling-app/issues/7273

...

This commit is contained in:

Adam Chalmers

2025-06-05 08:23:48 -05:00

committed by GitHub

parent 9136fb0d1b

commit 4575b32dbc

77 changed files with 3397 additions and 1987 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

BIN

public/kcl-samples/screenshots/ball-joint-rod-end.png

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 83 KiB After Width:  |  Height:  |  Size: 83 KiB