ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

KCL parser: Allow .prop or [index] to follow any expression (#7371)

Browse Source 
Previously in a member expression like `foo.x` or `foo[3]`, `foo` had to be an identifier. You could not do something like `f().x` (and if you tried, you got a cryptic error). Rather than make the error better, we should just accept any expression to be the LHS of a member expression (aka its 'object').

This does knock our "parse lots of function calls" from 58 to 55 calls before it stack overflows. But I think it's fine, we'll address this in https://github.com/KittyCAD/modeling-app/pull/6226 when I get back to it.

Closes https://github.com/KittyCAD/modeling-app/issues/7273
This commit is contained in:
Adam Chalmers
2025-06-05 08:23:48 -05:00
committed by GitHub
parent 9136fb0d1b
commit 4575b32dbc
77 changed files with 3397 additions and 1987 deletions
Download Patch File Download Diff File Expand all files Collapse all files

112
rust/kcl-lib/tests/union_cubes/ast.snap
View File

@ -83,12 +83,20 @@ description: Result of parsing union_cubes.kcl
"computed": false,
"end": 0,
"object": {
"abs_path": false,
"commentStart": 0,
"end": 0,
"name": "pos",
"name": {
"commentStart": 0,
"end": 0,
"name": "pos",
"start": 0,
"type": "Identifier"
},
"path": [],
"start": 0,
"type": "Identifier",
"type": "Identifier"
"type": "Name",
"type": "Name"
},
"property": {
"commentStart": 0,
@ -135,12 +143,20 @@ description: Result of parsing union_cubes.kcl
"computed": false,
"end": 0,
"object": {
"abs_path": false,
"commentStart": 0,
"end": 0,
"name": "pos",
"name": {
"commentStart": 0,
"end": 0,
"name": "pos",
"start": 0,
"type": "Identifier"
},
"path": [],
"start": 0,
"type": "Identifier",
"type": "Identifier"
"type": "Name",
"type": "Name"
},
"property": {
"commentStart": 0,
@ -231,12 +247,20 @@ description: Result of parsing union_cubes.kcl
"computed": false,
"end": 0,
"object": {
"abs_path": false,
"commentStart": 0,
"end": 0,
"name": "pos",
"name": {
"commentStart": 0,
"end": 0,
"name": "pos",
"start": 0,
"type": "Identifier"
},
"path": [],
"start": 0,
"type": "Identifier",
"type": "Identifier"
"type": "Name",
"type": "Name"
},
"property": {
"commentStart": 0,
@ -283,12 +307,20 @@ description: Result of parsing union_cubes.kcl
"computed": false,
"end": 0,
"object": {
"abs_path": false,
"commentStart": 0,
"end": 0,
"name": "pos",
"name": {
"commentStart": 0,
"end": 0,
"name": "pos",
"start": 0,
"type": "Identifier"
},
"path": [],
"start": 0,
"type": "Identifier",
"type": "Identifier"
"type": "Name",
"type": "Name"
},
"property": {
"commentStart": 0,
@ -379,12 +411,20 @@ description: Result of parsing union_cubes.kcl
"computed": false,
"end": 0,
"object": {
"abs_path": false,
"commentStart": 0,
"end": 0,
"name": "pos",
"name": {
"commentStart": 0,
"end": 0,
"name": "pos",
"start": 0,
"type": "Identifier"
},
"path": [],
"start": 0,
"type": "Identifier",
"type": "Identifier"
"type": "Name",
"type": "Name"
},
"property": {
"commentStart": 0,
@ -431,12 +471,20 @@ description: Result of parsing union_cubes.kcl
"computed": false,
"end": 0,
"object": {
"abs_path": false,
"commentStart": 0,
"end": 0,
"name": "pos",
"name": {
"commentStart": 0,
"end": 0,
"name": "pos",
"start": 0,
"type": "Identifier"
},
"path": [],
"start": 0,
"type": "Identifier",
"type": "Identifier"
"type": "Name",
"type": "Name"
},
"property": {
"commentStart": 0,
@ -527,12 +575,20 @@ description: Result of parsing union_cubes.kcl
"computed": false,
"end": 0,
"object": {
"abs_path": false,
"commentStart": 0,
"end": 0,
"name": "pos",
"name": {
"commentStart": 0,
"end": 0,
"name": "pos",
"start": 0,
"type": "Identifier"
},
"path": [],
"start": 0,
"type": "Identifier",
"type": "Identifier"
"type": "Name",
"type": "Name"
},
"property": {
"commentStart": 0,
@ -579,12 +635,20 @@ description: Result of parsing union_cubes.kcl
"computed": false,
"end": 0,
"object": {
"abs_path": false,
"commentStart": 0,
"end": 0,
"name": "pos",
"name": {
"commentStart": 0,
"end": 0,
"name": "pos",
"start": 0,
"type": "Identifier"
},
"path": [],
"start": 0,
"type": "Identifier",
"type": "Identifier"
"type": "Name",
"type": "Name"
},
"property": {
"commentStart": 0,