Refactor Fillet Logic to Combine Multiple Tags Within the Same Fillet Expression (#4058)

* combine tags + tests

* delete getFilletTag function

* fix playwright test

* make eslint happy

* delete missed 'const'

* delete const rev2
This commit is contained in:
max
2024-10-03 11:14:02 +02:00
committed by GitHub
parent c84c0b0fef
commit 46d335f916
4 changed files with 226 additions and 457 deletions

View File

@ -258,7 +258,6 @@ export const modelingMachineCommandConfig: StateMachineCommandSetConfig<
},
},
Fillet: {
// todo
description: 'Fillet edge',
icon: 'fillet',
needsReview: true,
@ -269,7 +268,7 @@ export const modelingMachineCommandConfig: StateMachineCommandSetConfig<
'default',
'line-end',
'line-mid',
'extrude-wall', // to fix: accepts only this selection type
'extrude-wall',
'solid2D',
'start-cap',
'end-cap',
@ -279,9 +278,9 @@ export const modelingMachineCommandConfig: StateMachineCommandSetConfig<
'arc',
'all',
],
multiple: true, // TODO: multiple selection like in extrude command
multiple: true,
required: true,
skip: true,
skip: false,
},
radius: {
inputType: 'kcl',