Fix the React Hooks complains, and _app for rust

src-tauri/src/main.rs

@@ -87,10 +87,10 @@ async fn login(app: tauri::AppHandle, host: &str) -> Result<String, InvokeError>
 
 fn main() {
     tauri::Builder::default()
-        .setup(|app| {
+        .setup(|_app| {
             #[cfg(debug_assertions)] // only include this code on debug builds
             {
-                let window = app.get_window("main").unwrap();
+                let window = _app.get_window("main").unwrap();
                 // comment out the below if you don't devtools to open everytime.
                 // it's useful because otherwise devtools shuts everytime rust code changes.
                 window.open_devtools();

src/App.tsx

@@ -286,7 +286,17 @@ export function App() {
     return () => {
       eng?.tearDown()
     }
-  }, [height, setEngineCommandManager, setIsStreamReady, setMediaStream, setStreamDimensions, token, width])
+  }, [
+    height,
+    quadHeight,
+    quadWidth,
+    setEngineCommandManager,
+    setIsStreamReady,
+    setMediaStream,
+    setStreamDimensions,
+    token,
+    width,
+  ])
 
   useEffect(() => {
     if (!isStreamReady) return
@@ -385,7 +395,23 @@ export function App() {
     return () => {
       unsubFn.forEach((fn) => fn())
     }
-  }, [defferedCode, isStreamReady, engineCommandManager])
+  }, [
+    defferedCode,
+    isStreamReady,
+    engineCommandManager,
+    setAst,
+    resetLogs,
+    resetKCLErrors,
+    setIsExecuting,
+    setArtifactMap,
+    setError,
+    highlightRange,
+    setHighlightRange,
+    setCursor2,
+    setProgramMemory,
+    addKCLError,
+    addLog,
+  ])
 
   const debounceSocketSend = throttle<EngineCommand>((message) => {
     engineCommandManager?.sendSceneCommand(message)

src/components/AvailableVarsHelpers.tsx

@@ -122,7 +122,7 @@ export function useCalc({
     if (ast) {
       setNewVariableName(findUniqueName(ast, valueName))
     }
-  }, [])
+  }, [ast, value, valueName])
 
   useEffect(() => {
     const allVarNames = Object.keys(programMemory.root)
@@ -131,7 +131,7 @@ export function useCalc({
     } else {
       setIsNewVariableNameUnique(true)
     }
-  }, [newVariableName])
+  }, [newVariableName, programMemory.root])
 
   useEffect(() => {
     if (!ast || !programMemory || !selectionRange) return
@@ -165,7 +165,7 @@ export function useCalc({
       setCalcResult('NAN')
       setValueNode(null)
     }
-  }, [value])
+  }, [availableVarInfo.variables, engineCommandManager, value])
 
   return {
     valueNode,

src/components/Toolbar/ConvertVariable.tsx

@@ -30,7 +30,7 @@ export const ConvertToVariable = () => {
 
     const _enableHorz = canReplace && isOnlyOneSelection
     setEnableAngLen(_enableHorz)
-  }, [guiMode, selectionRanges])
+  }, [ast, guiMode, selectionRanges])
 
   return (
     <button

src/components/Toolbar/EqualAngle.tsx

@@ -68,7 +68,7 @@ export const EqualAngle = () => {
       isOthersLinkedToPrimary &&
       theTransforms.every(Boolean)
     setEnableEqual(_enableEqual)
-  }, [guiMode, selectionRanges])
+  }, [ast, guiMode, selectionRanges])
   if (guiMode.mode !== 'sketch') return null
 
   return (

src/components/Toolbar/EqualLength.tsx

@@ -68,7 +68,7 @@ export const EqualLength = () => {
       isOthersLinkedToPrimary &&
       theTransforms.every(Boolean)
     setEnableEqual(_enableEqual)
-  }, [guiMode, selectionRanges])
+  }, [ast, guiMode, selectionRanges])
   if (guiMode.mode !== 'sketch') return null
 
   return (

src/components/Toolbar/HorzVert.tsx

@@ -47,7 +47,7 @@ export const HorzVert = ({
 
     const _enableHorz = isAllTooltips && theTransforms.every(Boolean)
     setEnableHorz(_enableHorz)
-  }, [guiMode, selectionRanges])
+  }, [ast, guiMode, horOrVert, selectionRanges])
   if (guiMode.mode !== 'sketch') return null
 
   return (

src/components/Toolbar/Intersect.tsx

@@ -119,7 +119,7 @@ export const Intersect = () => {
       theTransforms.every(Boolean) &&
       _forcedSelectionRanges?.codeBasedSelections?.[1]?.type === 'line-end'
     setEnable(_enableEqual)
-  }, [guiMode, selectionRanges])
+  }, [ast, guiMode, programMemory, selectionRanges])
   if (guiMode.mode !== 'sketch') return null
 
   return (

src/components/Toolbar/RemoveConstrainingValues.tsx

@@ -51,7 +51,7 @@ export const RemoveConstrainingValues = () => {
     } catch (e) {
       console.error(e)
     }
-  }, [guiMode, selectionRanges])
+  }, [ast, guiMode, selectionRanges])
   if (guiMode.mode !== 'sketch') return null
 
   return (

src/components/Toolbar/SetAbsDistance.tsx

@@ -77,7 +77,7 @@ export const SetAbsDistance = ({
       selectionRanges.codeBasedSelections.length === 1 &&
       (enableX || enableY)
     setEnableAngLen(_enableHorz)
-  }, [guiMode, selectionRanges])
+  }, [ast, disType, guiMode, selectionRanges])
   if (guiMode.mode !== 'sketch') return null
 
   const isAlign = buttonType === 'snapToYAxis' || buttonType === 'snapToXAxis'

src/components/Toolbar/SetAngleBetween.tsx

@@ -78,7 +78,7 @@ export const SetAngleBetween = () => {
       isOthersLinkedToPrimary &&
       theTransforms.every(Boolean)
     setEnable(_enableEqual)
-  }, [guiMode, selectionRanges])
+  }, [ast, guiMode, selectionRanges])
   if (guiMode.mode !== 'sketch') return null
 
   return (

src/components/Toolbar/SetHorzVertDistance.tsx

@@ -96,7 +96,7 @@ export const SetHorzVertDistance = ({
       isOthersLinkedToPrimary &&
       theTransforms.every(Boolean)
     setEnable(_enableEqual)
-  }, [guiMode, selectionRanges])
+  }, [ast, constraint, guiMode, selectionRanges])
   if (guiMode.mode !== 'sketch') return null
 
   const isAlign =

src/components/Toolbar/setAngleLength.tsx

@@ -59,7 +59,7 @@ export const SetAngleLength = ({
 
     const _enableHorz = isAllTooltips && theTransforms.every(Boolean)
     setEnableAngLen(_enableHorz)
-  }, [guiMode, selectionRanges])
+  }, [angleOrLength, ast, guiMode, selectionRanges])
   if (guiMode.mode !== 'sketch') return null
 
   return (

src/hooks/useStateMachineCommands.ts

@@ -38,5 +38,5 @@ export default function useStateMachineCommands<T extends AnyStateMachine>({
     return () => {
       removeCommands(newCommands)
     }
-  }, [state])
+  }, [addCommands, commandBarMeta, owner, removeCommands, send, state])
 }