Loft command prompt focus fix (#5080)

This commit is contained in:
Pierre Jacquier
2025-01-16 18:03:01 -05:00
committed by GitHub
parent d049bf33e8
commit 4ea1d16fb6
3 changed files with 2 additions and 14 deletions

View File

@ -829,12 +829,6 @@ loftPointAndClickCases.forEach(({ shouldPreselect }) => {
}) })
await selectSketches() await selectSketches()
await cmdBar.progressCmdBar() await cmdBar.progressCmdBar()
await cmdBar.expectState({
stage: 'review',
headerArguments: { Selection: '2 faces' },
commandName: 'Loft',
})
await cmdBar.progressCmdBar()
}) })
} else { } else {
await test.step(`Preselect the two sketches`, async () => { await test.step(`Preselect the two sketches`, async () => {
@ -844,12 +838,6 @@ loftPointAndClickCases.forEach(({ shouldPreselect }) => {
await test.step(`Go through the command bar flow with preselected sketches`, async () => { await test.step(`Go through the command bar flow with preselected sketches`, async () => {
await toolbar.loftButton.click() await toolbar.loftButton.click()
await cmdBar.progressCmdBar() await cmdBar.progressCmdBar()
await cmdBar.expectState({
stage: 'review',
headerArguments: { Selection: '2 faces' },
commandName: 'Loft',
})
await cmdBar.progressCmdBar()
}) })
} }

View File

@ -329,7 +329,7 @@ export const modelingMachineCommandConfig: StateMachineCommandSetConfig<
Loft: { Loft: {
description: 'Create a 3D body by blending between two or more sketches', description: 'Create a 3D body by blending between two or more sketches',
icon: 'loft', icon: 'loft',
needsReview: true, needsReview: false,
args: { args: {
selection: { selection: {
inputType: 'selection', inputType: 'selection',

View File

@ -96,7 +96,7 @@ export type CommandConfig<
Command<T, CommandName, CommandSchema>, Command<T, CommandName, CommandSchema>,
'name' | 'groupId' | 'onSubmit' | 'onCancel' | 'args' | 'needsReview' 'name' | 'groupId' | 'onSubmit' | 'onCancel' | 'args' | 'needsReview'
> & { > & {
needsReview?: true needsReview?: boolean
status?: 'active' | 'development' | 'inactive' status?: 'active' | 'development' | 'inactive'
args?: { args?: {
[ArgName in keyof CommandSchema]: CommandArgumentConfig< [ArgName in keyof CommandSchema]: CommandArgumentConfig<