allow for sketching on the face of a chamfer in kcl (#2760)

* updates

Signed-off-by: Jess Frazelle <github@jessfraz.com>

* cleanup

Signed-off-by: Jess Frazelle <github@jessfraz.com>

* lots of cleanup

Signed-off-by: Jess Frazelle <github@jessfraz.com>

* lots more cleanup

Signed-off-by: Jess Frazelle <github@jessfraz.com>

* updates

Signed-off-by: Jess Frazelle <github@jessfraz.com>

* more cleaniup

Signed-off-by: Jess Frazelle <github@jessfraz.com>

* fix typos

Signed-off-by: Jess Frazelle <github@jessfraz.com>

* add to known issues

Signed-off-by: Jess Frazelle <github@jessfraz.com>

* fixes

Signed-off-by: Jess Frazelle <github@jessfraz.com>

* updates

Signed-off-by: Jess Frazelle <github@jessfraz.com>

---------

Signed-off-by: Jess Frazelle <github@jessfraz.com>
This commit is contained in:
Jess Frazelle
2024-06-23 23:04:32 -07:00
committed by GitHub
parent 394653247a
commit 5260bd6820
59 changed files with 990 additions and 278 deletions

View File

@ -23,5 +23,7 @@ once fixed in engine will just start working here with no language changes.
- **Chamfers**: Chamfers cannot intersect, you will get an error. Only simple
chamfer cases work currently.
Sketching on the chamfered face does not currently work.
- **Shell**: Shell is only working for `end` faces, not for `side` or `start`
faces. We are tracking the engine side bug on this.

View File

@ -90,6 +90,7 @@ const extrusion = extrude(5, sketch001)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -91,6 +91,7 @@ const extrusion = extrude(5, sketch001)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -97,6 +97,7 @@ const example = extrude(10, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -371,6 +372,7 @@ const example = extrude(10, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -96,6 +96,7 @@ const extrusion = extrude(10, sketch001)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -370,6 +371,7 @@ const extrusion = extrude(10, sketch001)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -98,6 +98,7 @@ const example = extrude(10, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -372,6 +373,7 @@ const example = extrude(10, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -102,6 +102,7 @@ const example = extrude(10, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -376,6 +377,7 @@ const example = extrude(10, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -95,6 +95,7 @@ const example = extrude(10, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -369,6 +370,7 @@ const example = extrude(10, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -95,6 +95,7 @@ const example = extrude(10, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -369,6 +370,7 @@ const example = extrude(10, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -106,6 +106,7 @@ const exampleSketch = startSketchOn('XZ')
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -380,6 +381,7 @@ const exampleSketch = startSketchOn('XZ')
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -101,6 +101,7 @@ const example = extrude(10, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -375,6 +376,7 @@ const example = extrude(10, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -9,7 +9,7 @@ Create chamfers on tagged paths.
```js
chamfer(data: ChamferData, extrude_group: ExtrudeGroup) -> ExtrudeGroup
chamfer(data: ChamferData, extrude_group: ExtrudeGroup, tag?: String) -> ExtrudeGroup
```
### Examples
@ -73,6 +73,7 @@ string],
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -135,6 +136,7 @@ string],
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -295,6 +297,7 @@ string],
}],
}
```
* `tag`: `String` (OPTIONAL)
### Returns
@ -318,6 +321,7 @@ string],
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -380,6 +384,7 @@ string],
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -95,6 +95,7 @@ const example = extrude(5, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -287,6 +288,7 @@ const example = extrude(5, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -481,6 +483,7 @@ const example = extrude(5, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -96,6 +96,7 @@ const example = extrude(10, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -370,6 +371,7 @@ const example = extrude(10, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -121,6 +121,7 @@ const example = extrude(10, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -361,6 +362,7 @@ const example = extrude(10, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -423,6 +425,7 @@ const example = extrude(10, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -73,6 +73,7 @@ string],
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -135,6 +136,7 @@ string],
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -318,6 +320,7 @@ string],
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -380,6 +383,7 @@ string],
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -60,6 +60,7 @@ const revolution = startSketchOn(box, "revolveAxis")
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -122,6 +123,7 @@ const revolution = startSketchOn(box, "revolveAxis")
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -58,6 +58,7 @@ const example = extrude(5, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -120,6 +121,7 @@ const example = extrude(5, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -56,6 +56,7 @@ const example = extrude(5, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -118,6 +119,7 @@ const example = extrude(5, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -58,6 +58,7 @@ const example = extrude(5, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -120,6 +121,7 @@ const example = extrude(5, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -63,6 +63,7 @@ const part001 = startSketchOn('XY')
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -125,6 +126,7 @@ const part001 = startSketchOn('XY')
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -308,6 +310,7 @@ const part001 = startSketchOn('XY')
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -370,6 +373,7 @@ const part001 = startSketchOn('XY')
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -107,6 +107,7 @@ const example = extrude(1, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -381,6 +382,7 @@ const example = extrude(1, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -654,6 +656,7 @@ const example = extrude(1, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -87,6 +87,7 @@ const example = extrude(5, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -87,6 +87,7 @@ const example = extrude(5, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -100,6 +100,7 @@ const example = extrude(5, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -374,6 +375,7 @@ const example = extrude(5, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -87,6 +87,7 @@ const example = extrude(5, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -361,6 +362,7 @@ const example = extrude(5, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -105,6 +105,7 @@ const example = extrude(1, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -67,6 +67,7 @@ const example = extrude(-5, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -129,6 +130,7 @@ const example = extrude(-5, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -98,6 +98,7 @@ const example = extrude(1, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -65,6 +65,7 @@ const example = extrude(1, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -127,6 +128,7 @@ const example = extrude(1, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -88,6 +88,7 @@ const sketch001 = startSketchOn('XY')
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -83,6 +83,7 @@ const sketch001 = startSketchOn('XY')
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -82,6 +82,7 @@ const sketch001 = startSketchOn('XY')
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -216,6 +216,7 @@ string,
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -452,6 +453,7 @@ string,
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -514,6 +516,7 @@ string,
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -90,6 +90,7 @@ const example = extrude(4, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -88,6 +88,7 @@ const example = extrude(5, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -89,6 +89,7 @@ const example = extrude(5, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -90,6 +90,7 @@ const example = extrude(5, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -61,6 +61,7 @@ string],
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -123,6 +124,7 @@ string],
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -306,6 +308,7 @@ string],
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -368,6 +371,7 @@ string],
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -109,6 +109,7 @@ const example = extrude(5, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -365,6 +366,7 @@ const example = extrude(5, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -113,6 +113,7 @@ const example = extrude(5, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -9,7 +9,7 @@ Start a sketch on a specific plane or face.
```js
startSketchOn(data: SketchData, tag?: SketchOnFaceTag) -> SketchSurface
startSketchOn(data: SketchData, tag?: FaceTag) -> SketchSurface
```
### Examples
@ -178,6 +178,7 @@ const a1 = startSketchOn({
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -349,7 +350,7 @@ const a1 = startSketchOn({
}],
}
```
* `tag`: `SketchOnFaceTag` - A tag for sketch on face. (OPTIONAL)
* `tag`: `FaceTag` - A tag for a face. (OPTIONAL)
```js
"start" | "end" |
string
@ -410,6 +411,7 @@ string
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

File diff suppressed because it is too large Load Diff

View File

@ -96,6 +96,7 @@ const example = extrude(10, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -370,6 +371,7 @@ const example = extrude(10, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -87,6 +87,7 @@ const example = extrude(10, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -361,6 +362,7 @@ const example = extrude(10, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -90,6 +90,7 @@ const example = extrude(10, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -364,6 +365,7 @@ const example = extrude(10, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -90,6 +90,7 @@ const example = extrude(10, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -364,6 +365,7 @@ const example = extrude(10, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -88,6 +88,7 @@ const example = extrude(10, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -362,6 +363,7 @@ const example = extrude(10, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.

View File

@ -86,6 +86,7 @@ const example = extrude(5, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.
@ -360,6 +361,7 @@ const example = extrude(5, exampleSketch)
// The id of the engine command that called this chamfer.
id: uuid,
length: number,
tag: string,
type: "chamfer",
}],
// The height of the extrude group.