ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix diagnostic fighting between wasm and typescript (closes #2755) (#2799)

Browse Source 
* start to gut and seperate the kcl lint from execute

* fix type signature

* re-add old codepath when not wasm

* also lint in the mock

* fix syntax

* fix message
This commit is contained in:
Paul Tagliamonte
2024-06-26 00:04:52 -04:00
committed by GitHub
parent 289ed291c4
commit 53db421d97
7 changed files with 79 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/wasm-lib/kcl/src/lint/rule.rs
View File

@ -1,4 +1,6 @@
use anyhow::Result;
use schemars::JsonSchema;
use serde::Serialize;
use tower_lsp::lsp_types::{Diagnostic, DiagnosticSeverity};
use crate::{executor::SourceRange, lint::Node, lsp::IntoDiagnostic};
@ -22,8 +24,10 @@ where
}
/// Specific discovered lint rule Violation of a particular Finding.
#[derive(Clone, Debug)]
#[derive(Clone, Debug, ts_rs::TS, Serialize, JsonSchema)]
#[ts(export)]
#[cfg_attr(feature = "pyo3", pyo3::pyclass)]
#[serde(rename_all = "camelCase")]
pub struct Discovered {
/// Zoo Lint Finding information.
pub finding: Finding,
@ -83,8 +87,10 @@ impl IntoDiagnostic for Discovered {
}
/// Abstract lint problem type.
#[derive(Clone, Debug, PartialEq)]
#[derive(Clone, Debug, PartialEq, ts_rs::TS, Serialize, JsonSchema)]
#[ts(export)]
#[cfg_attr(feature = "pyo3", pyo3::pyclass)]
#[serde(rename_all = "camelCase")]
pub struct Finding {
/// Unique identifier for this particular issue.
pub code: &'static str,