ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add "report a bug" mention to user menu onboarding step (#3278)

Browse Source 
* Mention "report a bug" in user menu onboarding step

* Add to a test so we match QAWolf a bit more

* Re-run CI
This commit is contained in:
Frank Noirot
2024-08-05 08:24:19 -04:00
committed by GitHub
parent 61b669cf4e
commit 543e809739
2 changed files with 18 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
e2e/playwright/flow-tests.spec.ts
View File

@ -2535,18 +2535,29 @@ test.describe('Onboarding tests', () => {
await page.waitForURL('**/file/**', { waitUntil: 'domcontentloaded' }) await page.waitForURL('**/file/**', { waitUntil: 'domcontentloaded' })
// Test that the text in this step is correct // Test that the text in this step is correct
const avatarLocator = await page const sidebar = page.getByTestId('user-sidebar-toggle')
.getByTestId('user-sidebar-toggle') const avatar = sidebar.locator('img')
.locator('img') const onboardingOverlayLocator = page
const onboardingOverlayLocator = await page
.getByTestId('onboarding-content') .getByTestId('onboarding-content')
.locator('div') .locator('div')
.nth(1) .nth(1)
// Expect the avatar to be visible and for the text to reference it // Expect the avatar to be visible and for the text to reference it
await expect(avatarLocator).not.toBeVisible() await expect(avatar).not.toBeVisible()
await expect(onboardingOverlayLocator).toBeVisible() await expect(onboardingOverlayLocator).toBeVisible()
await expect(onboardingOverlayLocator).toContainText('the menu button') await expect(onboardingOverlayLocator).toContainText('the menu button')
// Test we mention what else is in this menu for https://github.com/KittyCAD/modeling-app/issues/2939
// which doesn't deserver its own full test spun up
const userMenuFeatures = [
'manage your account',
'report a bug',
'request a feature',
'sign out',
]
for (const feature of userMenuFeatures) {
await expect(onboardingOverlayLocator).toContainText(feature)
}
}) })
}) })

4
src/routes/Onboarding/UserMenu.tsx
View File

@ -43,8 +43,8 @@ export default function UserMenu() {
<h2 className="text-2xl font-bold">User Menu</h2> <h2 className="text-2xl font-bold">User Menu</h2>
<p className="my-4"> <p className="my-4">
Click {buttonDescription} in the upper right to open the user menu. Click {buttonDescription} in the upper right to open the user menu.
You can change your user-level settings, sign out, or request a You can change your user-level settings, sign out, report a bug,
feature. manage your account, request a feature, and more.
</p> </p>
<p className="my-4"> <p className="my-4">
Many settings can be set either a user or per-project level. User Many settings can be set either a user or per-project level. User