ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add a test step to confirm the solid bg of the settings dialog (#3927)

Browse Source
This commit is contained in:
Frank Noirot
2024-09-20 12:04:36 -04:00
committed by GitHub
parent 01cc9e751b
commit 5512f99997
1 changed files with 24 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
e2e/playwright/testing-settings.spec.ts
View File

@ -69,12 +69,15 @@ test.describe('Testing settings', () => {
page, page,
}) => { }) => {
const u = await getUtils(page) const u = await getUtils(page)
await page.setViewportSize({ width: 1200, height: 500 }) await test.step(`Setup`, async () => {
await u.waitForAuthSkipAppStart() await page.setViewportSize({ width: 1200, height: 500 })
await page await u.waitForAuthSkipAppStart()
.getByRole('button', { name: 'Start Sketch' }) await page
.waitFor({ state: 'visible' }) .getByRole('button', { name: 'Start Sketch' })
.waitFor({ state: 'visible' })
})
// Selectors and constants
const paneButtonLocator = page.getByTestId('debug-pane-button') const paneButtonLocator = page.getByTestId('debug-pane-button')
const headingLocator = page.getByRole('heading', { const headingLocator = page.getByRole('heading', {
name: 'Settings', name: 'Settings',
@ -82,11 +85,23 @@ test.describe('Testing settings', () => {
}) })
const inputLocator = page.locator('input[name="modeling-showDebugPanel"]') const inputLocator = page.locator('input[name="modeling-showDebugPanel"]')
// Open the settings modal with the browser keyboard shortcut await test.step('Open settings dialog and set "Show debug panel" to on', async () => {
await page.keyboard.press('ControlOrMeta+Shift+,') await page.keyboard.press('ControlOrMeta+Shift+,')
await expect(headingLocator).toBeVisible()
await expect(headingLocator).toBeVisible() /** Test to close https://github.com/KittyCAD/modeling-app/issues/2713 */
await page.locator('#showDebugPanel').getByText('OffOn').click() await test.step(`Confirm that this dialog has a solid background`, async () => {
await expect
.poll(() => u.getGreatestPixDiff({ x: 600, y: 250 }, [28, 28, 28]), {
timeout: 1000,
message:
'Checking for solid background, should not see default plane colors',
})
.toBeLessThan(15)
})
await page.locator('#showDebugPanel').getByText('OffOn').click()
})
// Close it and open again with keyboard shortcut, while KCL editor is focused // Close it and open again with keyboard shortcut, while KCL editor is focused
// Put the cursor in the editor // Put the cursor in the editor