ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Change unit conversion functions to operate on input rather than return a conversion factor (#6181)

Browse Source 
Signed-off-by: Nick Cameron <nrc@ncameron.org>
This commit is contained in:
Nick Cameron
2025-04-08 14:21:23 +12:00
committed by GitHub
parent 6a5b23f848
commit 5b653fb558
39 changed files with 1551 additions and 1452 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
rust/kcl-lib/tests/kcl_samples/car-wheel-assembly/artifact_commands.snap
View File

@ -8440,7 +8440,7 @@ description: Artifact commands car-wheel-assembly.kcl
"type": "move_path_pen",
"path": "[uuid]",
"to": {
"x": 0.47244094488188976,
"x": 0.4724409448818898,
"y": 0.0,
"z": 0.0
}
@ -8512,7 +8512,7 @@ description: Artifact commands car-wheel-assembly.kcl
"path": "[uuid]",
"segment": {
"type": "tangential_arc",
"radius": 0.11811023622047244,
"radius": 0.11811023622047245,
"offset": {
"unit": "degrees",
"value": 90.0

156
rust/kcl-lib/tests/kcl_samples/car-wheel-assembly/artifact_graph_flowchart.snap.md
View File

@ -79,85 +79,85 @@ flowchart LR
158[Solid2d]
end
subgraph path167 [Path]
167["Path<br>[1241, 1301, 5]"]
168["Segment<br>[1241, 1301, 5]"]
167["Path<br>[1241, 1302, 5]"]
168["Segment<br>[1241, 1302, 5]"]
169[Solid2d]
end
subgraph path179 [Path]
179["Path<br>[1659, 1705, 5]"]
180["Segment<br>[1711, 1763, 5]"]
181["Segment<br>[1769, 1874, 5]"]
182["Segment<br>[1880, 1902, 5]"]
183["Segment<br>[1908, 1964, 5]"]
184["Segment<br>[1970, 1977, 5]"]
179["Path<br>[1660, 1706, 5]"]
180["Segment<br>[1712, 1764, 5]"]
181["Segment<br>[1770, 1875, 5]"]
182["Segment<br>[1881, 1903, 5]"]
183["Segment<br>[1909, 1965, 5]"]
184["Segment<br>[1971, 1978, 5]"]
185[Solid2d]
end
subgraph path195 [Path]
195["Path<br>[2109, 2155, 5]"]
196["Segment<br>[2161, 2213, 5]"]
197["Segment<br>[2219, 2326, 5]"]
198["Segment<br>[2332, 2369, 5]"]
199["Segment<br>[2375, 2431, 5]"]
200["Segment<br>[2437, 2444, 5]"]
195["Path<br>[2110, 2156, 5]"]
196["Segment<br>[2162, 2214, 5]"]
197["Segment<br>[2220, 2327, 5]"]
198["Segment<br>[2333, 2370, 5]"]
199["Segment<br>[2376, 2432, 5]"]
200["Segment<br>[2438, 2445, 5]"]
201[Solid2d]
end
subgraph path212 [Path]
212["Path<br>[2953, 3000, 5]"]
213["Segment<br>[3008, 3348, 5]"]
214["Segment<br>[3356, 3388, 5]"]
215["Segment<br>[3396, 3740, 5]"]
216["Segment<br>[3748, 3804, 5]"]
217["Segment<br>[3812, 3819, 5]"]
212["Path<br>[2954, 3001, 5]"]
213["Segment<br>[3009, 3349, 5]"]
214["Segment<br>[3357, 3389, 5]"]
215["Segment<br>[3397, 3741, 5]"]
216["Segment<br>[3749, 3805, 5]"]
217["Segment<br>[3813, 3820, 5]"]
218[Solid2d]
end
subgraph path235 [Path]
235["Path<br>[2953, 3000, 5]"]
236["Segment<br>[3008, 3348, 5]"]
237["Segment<br>[3356, 3388, 5]"]
238["Segment<br>[3396, 3740, 5]"]
239["Segment<br>[3748, 3804, 5]"]
240["Segment<br>[3812, 3819, 5]"]
235["Path<br>[2954, 3001, 5]"]
236["Segment<br>[3009, 3349, 5]"]
237["Segment<br>[3357, 3389, 5]"]
238["Segment<br>[3397, 3741, 5]"]
239["Segment<br>[3749, 3805, 5]"]
240["Segment<br>[3813, 3820, 5]"]
241[Solid2d]
end
subgraph path258 [Path]
258["Path<br>[4347, 4442, 5]"]
259["Segment<br>[4448, 4481, 5]"]
260["Segment<br>[4487, 4538, 5]"]
261["Segment<br>[4544, 4577, 5]"]
262["Segment<br>[4583, 4633, 5]"]
263["Segment<br>[4639, 4680, 5]"]
264["Segment<br>[4686, 4735, 5]"]
265["Segment<br>[4741, 4774, 5]"]
266["Segment<br>[4780, 4814, 5]"]
267["Segment<br>[4820, 4854, 5]"]
268["Segment<br>[4860, 4912, 5]"]
269["Segment<br>[4918, 4952, 5]"]
270["Segment<br>[4958, 5034, 5]"]
271["Segment<br>[5040, 5073, 5]"]
272["Segment<br>[5079, 5155, 5]"]
273["Segment<br>[5161, 5195, 5]"]
274["Segment<br>[5201, 5275, 5]"]
275["Segment<br>[5281, 5315, 5]"]
276["Segment<br>[5321, 5372, 5]"]
277["Segment<br>[5378, 5440, 5]"]
278["Segment<br>[5446, 5497, 5]"]
279["Segment<br>[5503, 5537, 5]"]
280["Segment<br>[5543, 5576, 5]"]
281["Segment<br>[5582, 5615, 5]"]
282["Segment<br>[5621, 5628, 5]"]
258["Path<br>[4348, 4443, 5]"]
259["Segment<br>[4449, 4482, 5]"]
260["Segment<br>[4488, 4539, 5]"]
261["Segment<br>[4545, 4578, 5]"]
262["Segment<br>[4584, 4634, 5]"]
263["Segment<br>[4640, 4681, 5]"]
264["Segment<br>[4687, 4736, 5]"]
265["Segment<br>[4742, 4775, 5]"]
266["Segment<br>[4781, 4815, 5]"]
267["Segment<br>[4821, 4855, 5]"]
268["Segment<br>[4861, 4913, 5]"]
269["Segment<br>[4919, 4953, 5]"]
270["Segment<br>[4959, 5035, 5]"]
271["Segment<br>[5041, 5074, 5]"]
272["Segment<br>[5080, 5156, 5]"]
273["Segment<br>[5162, 5196, 5]"]
274["Segment<br>[5202, 5276, 5]"]
275["Segment<br>[5282, 5316, 5]"]
276["Segment<br>[5322, 5373, 5]"]
277["Segment<br>[5379, 5441, 5]"]
278["Segment<br>[5447, 5498, 5]"]
279["Segment<br>[5504, 5538, 5]"]
280["Segment<br>[5544, 5577, 5]"]
281["Segment<br>[5583, 5616, 5]"]
282["Segment<br>[5622, 5629, 5]"]
283[Solid2d]
end
subgraph path334 [Path]
334["Path<br>[744, 784, 8]"]
335["Segment<br>[792, 854, 8]"]
336["Segment<br>[862, 898, 8]"]
337["Segment<br>[906, 936, 8]"]
338["Segment<br>[944, 996, 8]"]
339["Segment<br>[1004, 1044, 8]"]
340["Segment<br>[1052, 1087, 8]"]
341["Segment<br>[1095, 1133, 8]"]
342["Segment<br>[1141, 1163, 8]"]
343["Segment<br>[1171, 1178, 8]"]
334["Path<br>[745, 785, 8]"]
335["Segment<br>[793, 855, 8]"]
336["Segment<br>[863, 899, 8]"]
337["Segment<br>[907, 937, 8]"]
338["Segment<br>[945, 998, 8]"]
339["Segment<br>[1006, 1046, 8]"]
340["Segment<br>[1054, 1089, 8]"]
341["Segment<br>[1097, 1135, 8]"]
342["Segment<br>[1143, 1165, 8]"]
343["Segment<br>[1173, 1180, 8]"]
344[Solid2d]
end
subgraph path365 [Path]
@ -315,16 +315,16 @@ flowchart LR
164["Sweep Extrusion<br>[1110, 1144, 5]"]
165["Sweep Extrusion<br>[1110, 1144, 5]"]
166["Sweep Extrusion<br>[1110, 1144, 5]"]
170["Sweep Extrusion<br>[1448, 1482, 5]"]
170["Sweep Extrusion<br>[1449, 1483, 5]"]
171[Wall]
172["SweepEdge Opposite"]
173["SweepEdge Adjacent"]
174["Sweep Extrusion<br>[1448, 1482, 5]"]
175["Sweep Extrusion<br>[1448, 1482, 5]"]
176["Sweep Extrusion<br>[1448, 1482, 5]"]
177["Sweep Extrusion<br>[1448, 1482, 5]"]
178["Plane<br>[1636, 1653, 5]"]
186["Sweep Revolve<br>[1983, 2000, 5]"]
174["Sweep Extrusion<br>[1449, 1483, 5]"]
175["Sweep Extrusion<br>[1449, 1483, 5]"]
176["Sweep Extrusion<br>[1449, 1483, 5]"]
177["Sweep Extrusion<br>[1449, 1483, 5]"]
178["Plane<br>[1637, 1654, 5]"]
186["Sweep Revolve<br>[1984, 2001, 5]"]
187[Wall]
188[Wall]
189[Wall]
@ -332,8 +332,8 @@ flowchart LR
191["SweepEdge Adjacent"]
192["SweepEdge Adjacent"]
193["SweepEdge Adjacent"]
194["Plane<br>[2086, 2103, 5]"]
202["Sweep Revolve<br>[2450, 2467, 5]"]
194["Plane<br>[2087, 2104, 5]"]
202["Sweep Revolve<br>[2451, 2468, 5]"]
203[Wall]
204[Wall]
205[Wall]
@ -342,8 +342,8 @@ flowchart LR
208["SweepEdge Adjacent"]
209["SweepEdge Adjacent"]
210["SweepEdge Adjacent"]
211["Plane<br>[2922, 2945, 5]"]
219["Sweep Extrusion<br>[3867, 3913, 5]"]
211["Plane<br>[2923, 2946, 5]"]
219["Sweep Extrusion<br>[3868, 3914, 5]"]
220[Wall]
221[Wall]
222[Wall]
@ -358,8 +358,8 @@ flowchart LR
231["SweepEdge Adjacent"]
232["SweepEdge Opposite"]
233["SweepEdge Adjacent"]
234["Plane<br>[2922, 2945, 5]"]
242["Sweep Extrusion<br>[3867, 3913, 5]"]
234["Plane<br>[2923, 2946, 5]"]
242["Sweep Extrusion<br>[3868, 3914, 5]"]
243[Wall]
244[Wall]
245[Wall]
@ -374,8 +374,8 @@ flowchart LR
254["SweepEdge Adjacent"]
255["SweepEdge Opposite"]
256["SweepEdge Adjacent"]
257["Plane<br>[4324, 4341, 5]"]
284["Sweep Revolve<br>[5634, 5651, 5]"]
257["Plane<br>[4325, 4342, 5]"]
284["Sweep Revolve<br>[5635, 5652, 5]"]
285[Wall]
286[Wall]
287[Wall]
@ -424,8 +424,8 @@ flowchart LR
330["SweepEdge Adjacent"]
331["SweepEdge Adjacent"]
332["SweepEdge Adjacent"]
333["Plane<br>[710, 736, 8]"]
345["Sweep Revolve<br>[1186, 1203, 8]"]
333["Plane<br>[711, 737, 8]"]
345["Sweep Revolve<br>[1188, 1205, 8]"]
346[Wall]
347[Wall]
348[Wall]

12
rust/kcl-lib/tests/kcl_samples/car-wheel-assembly/ops.snap
View File

@ -1233,8 +1233,8 @@ description: Operations executed car-wheel-assembly.kcl
"type": "FunctionCall",
"name": "spoke",
"functionSourceRange": [
2620,
4193,
2621,
4194,
5
],
"unlabeledArg": null,
@ -1624,8 +1624,8 @@ description: Operations executed car-wheel-assembly.kcl
"type": "FunctionCall",
"name": "spoke",
"functionSourceRange": [
2620,
4193,
2621,
4194,
5
],
"unlabeledArg": null,
@ -2128,8 +2128,8 @@ description: Operations executed car-wheel-assembly.kcl
"type": "FunctionCall",
"name": "lug",
"functionSourceRange": [
668,
1293,
669,
1295,
8
],
"unlabeledArg": null,