Enhance helixes (#4973)
* updates Signed-off-by: Jess Frazelle <github@jessfraz.com> * updates Signed-off-by: Jess Frazelle <github@jessfraz.com> * updates Signed-off-by: Jess Frazelle <github@jessfraz.com> * allow a helix to go into a sweep Signed-off-by: Jess Frazelle <github@jessfraz.com> * fix clippy Signed-off-by: Jess Frazelle <github@jessfraz.com> * updates Signed-off-by: Jess Frazelle <github@jessfraz.com> * udpates Signed-off-by: Jess Frazelle <github@jessfraz.com> * updates Signed-off-by: Jess Frazelle <github@jessfraz.com> * snapshots Signed-off-by: Jess Frazelle <github@jessfraz.com> * docs Signed-off-by: Jess Frazelle <github@jessfraz.com> * docs Signed-off-by: Jess Frazelle <github@jessfraz.com> * fix Signed-off-by: Jess Frazelle <github@jessfraz.com> * updates Signed-off-by: Jess Frazelle <github@jessfraz.com> * updates Signed-off-by: Jess Frazelle <github@jessfraz.com> * updates Signed-off-by: Jess Frazelle <github@jessfraz.com> * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores) * updates Signed-off-by: Jess Frazelle <github@jessfraz.com> * updates Signed-off-by: Jess Frazelle <github@jessfraz.com> * docs Signed-off-by: Jess Frazelle <github@jessfraz.com> * updates Signed-off-by: Jess Frazelle <github@jessfraz.com> * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores) * em,pty * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores) * updates Signed-off-by: Jess Frazelle <github@jessfraz.com> * updates Signed-off-by: Jess Frazelle <github@jessfraz.com> --------- Signed-off-by: Jess Frazelle <github@jessfraz.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This commit is contained in:
@ -285,7 +285,7 @@ async fn optional_params() {
|
||||
fn other_circle = (pos, radius, tag?) => {
|
||||
sg = startSketchOn('XY')
|
||||
|> startProfileAt(pos, %)
|
||||
|> arc({angle_end: 360, angle_start: 0, radius: radius}, %)
|
||||
|> arc({angleEnd: 360, angleStart: 0, radius: radius}, %)
|
||||
|> close(%)
|
||||
|> extrude(2, %)
|
||||
|
||||
@ -1160,8 +1160,8 @@ async fn kcl_test_plumbus_fillets() {
|
||||
sg = startSketchOn(ext, face)
|
||||
|> startProfileAt([pos[0] + radius, pos[1]], %)
|
||||
|> arc({
|
||||
angle_end: 360,
|
||||
angle_start: 0,
|
||||
angleEnd: 360,
|
||||
angleStart: 0,
|
||||
radius: radius
|
||||
}, %, $arc1)
|
||||
|> close(%)
|
||||
@ -1235,9 +1235,9 @@ async fn kcl_test_member_expression_in_params() {
|
||||
y: originStart[1],
|
||||
z: originStart[2],
|
||||
},
|
||||
x_axis: { x: 0, y: 0, z: -1 },
|
||||
y_axis: { x: 1, y: 0, z: 0 },
|
||||
z_axis: { x: 0, y: 1, z: 0 }
|
||||
xAxis: { x: 0, y: 0, z: -1 },
|
||||
yAxis: { x: 1, y: 0, z: 0 },
|
||||
zAxis: { x: 0, y: 1, z: 0 }
|
||||
}
|
||||
})
|
||||
|> circle({ center: [0, 0], radius: capDia / 2 }, %)
|
||||
@ -1732,8 +1732,8 @@ async fn kcl_test_arc_error_same_start_end() {
|
||||
let code = r#"startSketchOn('XY')
|
||||
|> startProfileAt([10, 0], %)
|
||||
|> arc({
|
||||
angle_start: 180,
|
||||
angle_end: 180,
|
||||
angleStart: 180,
|
||||
angleEnd: 180,
|
||||
radius: 1.5
|
||||
}, %)
|
||||
|> close(%)
|
||||
@ -1749,7 +1749,7 @@ async fn kcl_test_arc_error_same_start_end() {
|
||||
assert!(result.is_err());
|
||||
assert_eq!(
|
||||
result.err().unwrap().to_string(),
|
||||
r#"type: KclErrorDetails { source_ranges: [SourceRange([57, 140, 0])], message: "Arc start and end angles must be different" }"#
|
||||
r#"type: KclErrorDetails { source_ranges: [SourceRange([57, 138, 0])], message: "Arc start and end angles must be different" }"#
|
||||
);
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user