From 5ff1d9e268c3c1b4f1a01abc033ac6ae09a3328f Mon Sep 17 00:00:00 2001
From: Pierre Jacquier <pierrejacquier39@gmail.com>
Date: Mon, 25 Nov 2024 16:14:40 -0500
Subject: [PATCH] Open about section links externally in Settings (#4571)

* Open nightly download link externally

* Applied to other about links
---
 src/components/Settings/AllSettingsFields.tsx | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/src/components/Settings/AllSettingsFields.tsx b/src/components/Settings/AllSettingsFields.tsx
index b64e8aab0..21c598962 100644
--- a/src/components/Settings/AllSettingsFields.tsx
+++ b/src/components/Settings/AllSettingsFields.tsx
@@ -24,6 +24,7 @@ import { ForwardedRef, forwardRef, useEffect } from 'react'
 import { useLspContext } from 'components/LspProvider'
 import { toSync } from 'lib/utils'
 import { reportRejection } from 'lib/trap'
+import { openExternalBrowserIfDesktop } from 'lib/openWindow'
 
 interface AllSettingsFieldsProps {
   searchParamTab: SettingsLevel
@@ -245,6 +246,9 @@ export const AllSettingsFields = forwardRef(
                   to inject the version from package.json */}
               App version {APP_VERSION}.{' '}
               <a
+                onClick={openExternalBrowserIfDesktop(
+                  `https://github.com/KittyCAD/modeling-app/releases/tag/v${APP_VERSION}`
+                )}
                 href={`https://github.com/KittyCAD/modeling-app/releases/tag/v${APP_VERSION}`}
                 target="_blank"
                 rel="noopener noreferrer"
@@ -255,6 +259,9 @@ export const AllSettingsFields = forwardRef(
             <p className="max-w-2xl mt-6">
               Don't see the feature you want? Check to see if it's on{' '}
               <a
+                onClick={openExternalBrowserIfDesktop(
+                  'https://github.com/KittyCAD/modeling-app/discussions'
+                )}
                 href="https://github.com/KittyCAD/modeling-app/discussions"
                 target="_blank"
                 rel="noopener noreferrer"
@@ -269,6 +276,9 @@ export const AllSettingsFields = forwardRef(
                 Want to experience the latest and (hopefully) greatest from our
                 main development branch?{' '}
                 <a
+                  onClick={openExternalBrowserIfDesktop(
+                    'https://zoo.dev/modeling-app/download/nightly'
+                  )}
                   href="https://zoo.dev/modeling-app/download/nightly"
                   target="_blank"
                   rel="noopener noreferrer"