ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

selections fix follow up (#1019)

Browse Source
This commit is contained in:
Kurt Hutten
2023-11-08 10:10:30 +11:00
committed by GitHub
parent b1668410f8
commit 604d931962
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/hooks/useEngineConnectionSubscriptions.ts
View File

@ -32,11 +32,10 @@ export function useEngineConnectionSubscriptions() {
const unSubClick = engineCommandManager.subscribeTo({ const unSubClick = engineCommandManager.subscribeTo({
event: 'select_with_point', event: 'select_with_point',
callback: async (engineEvent) => { callback: async (engineEvent) => {
if (!context.sketchEnginePathId) return
const event = await getEventForSelectWithPoint(engineEvent, { const event = await getEventForSelectWithPoint(engineEvent, {
sketchEnginePathId: context.sketchEnginePathId, sketchEnginePathId: context.sketchEnginePathId,
}) })
send(event) event && send(event)
}, },
}) })
return () => { return () => {

5
src/lib/selections.ts
View File

@ -102,8 +102,8 @@ export async function getEventForSelectWithPoint(
Models['OkModelingCmdResponse_type'], Models['OkModelingCmdResponse_type'],
{ type: 'select_with_point' } { type: 'select_with_point' }
>, >,
{ sketchEnginePathId }: { sketchEnginePathId: string } { sketchEnginePathId }: { sketchEnginePathId?: string }
): Promise<ModelingMachineEvent> { ): Promise<ModelingMachineEvent | null> {
if (!data?.entity_id) { if (!data?.entity_id) {
return { return {
type: 'Set selection', type: 'Set selection',
@ -120,6 +120,7 @@ export async function getEventForSelectWithPoint(
}, },
} }
} }
if (!sketchEnginePathId) return null
// selected a vertex // selected a vertex
const res = await engineCommandManager.sendSceneCommand({ const res = await engineCommandManager.sendSceneCommand({
type: 'modeling_cmd_req', type: 'modeling_cmd_req',