ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Adding dark edge lines in light mode + enabling SSAO (#2219)

Browse Source 
* adding dark edge lines in light mode + enabling SSAO

* A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu)

* Rerun CI

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Frank Noirot <frank@zoo.dev>
Co-authored-by: Frank Noirot <frank@kittycad.io>
This commit is contained in:
mlfarrell
2024-04-24 13:59:25 -07:00
committed by GitHub
parent cc6dee8ad4
commit 60c4969322
7 changed files with 60 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/lang/std/engineConnection.ts
View File

@ -4,7 +4,7 @@ import { Models } from '@kittycad/lib'
import { exportSave } from 'lib/exportSave'
import { uuidv4 } from 'lib/utils'
import { getNodePathFromSourceRange } from 'lang/queryAst'
import { Themes, getThemeColorForEngine } from 'lib/theme'
import { Themes, getThemeColorForEngine, getOppositeTheme } from 'lib/theme'
import { DefaultPlanes } from 'wasm-lib/kcl/bindings/DefaultPlanes'
let lastMessage = ''
@ -941,6 +941,7 @@ export class EngineCommandManager {
settings = {
theme: Themes.Dark,
highlightEdges: true,
enableSSAO: true,
},
}: {
setMediaStream: (stream: MediaStream) => void
@ -953,6 +954,7 @@ export class EngineCommandManager {
settings?: {
theme: Themes
highlightEdges: boolean
enableSSAO: boolean
}
}) {
this.makeDefaultPlanes = makeDefaultPlanes
@ -969,7 +971,8 @@ export class EngineCommandManager {
return
}
const url = `${VITE_KC_API_WS_MODELING_URL}?video_res_width=${width}&video_res_height=${height}`
const additionalSettings = settings.enableSSAO ? '&post_effect=ssao' : ''
const url = `${VITE_KC_API_WS_MODELING_URL}?video_res_width=${width}&video_res_height=${height}${additionalSettings}`
this.engineConnection = new EngineConnection({
engineCommandManager: this,
url,
@ -989,6 +992,18 @@ export class EngineCommandManager {
color: getThemeColorForEngine(settings.theme),
},
})
// Sets the default line colors
const opposingTheme = getOppositeTheme(settings.theme)
this.sendSceneCommand({
cmd_id: uuidv4(),
type: 'modeling_cmd_req',
cmd: {
type: 'set_default_system_properties',
color: getThemeColorForEngine(opposingTheme),
},
})
// Set the edge lines visibility
this.sendSceneCommand({
type: 'modeling_cmd_req',