From 615b7feabb473c26c40fd5c30376547e68c663b7 Mon Sep 17 00:00:00 2001 From: 49fl Date: Wed, 26 Feb 2025 12:09:38 -0500 Subject: [PATCH] Don't toss logs on successful snapshot tests (#5522) --- .github/workflows/e2e-tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yml index 9b7a4e38e..2cea2aa99 100644 --- a/.github/workflows/e2e-tests.yml +++ b/.github/workflows/e2e-tests.yml @@ -142,7 +142,7 @@ jobs: # TODO: break this in its own job, for now it's not slowing down the overall execution as ubuntu is the quickest, # but we could do better. This forces a large 1/1 shard of all 20 snapshot tests that runs in about 3 minutes. run: | - PLATFORM=web yarn playwright test --config=playwright.config.ts --retries="3" --update-snapshots --grep=@snapshot --shard=1/1 + PLATFORM=web yarn playwright test --config=playwright.config.ts --retries="3" --update-snapshots --grep=@snapshot --trace=on --shard=1/1 env: CI: true NODE_ENV: development @@ -153,7 +153,7 @@ jobs: - uses: actions/upload-artifact@v4 if: ${{ !cancelled() && (success() || failure()) }} with: - name: playwright-report-${{ matrix.os }}-snapshot-${{ matrix.shardIndex }}-${{ github.sha }} + name: playwright-report-snapshots-${{ matrix.os }}-snapshot-${{ matrix.shardIndex }}-${{ github.sha }} path: playwright-report/ include-hidden-files: true retention-days: 30