ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't let too-tall line height goof up action buttons (#6253)

Browse Source
This commit is contained in:
Frank Noirot
2025-04-11 14:06:36 -04:00
committed by GitHub
parent 72ab72cea1
commit 66f95d25f6
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/components/ActionButton.tsx
View File

@ -44,7 +44,7 @@ export type ActionButtonProps =
| ActionButtonAsElement
export const ActionButton = forwardRef((props: ActionButtonProps, ref) => {
const classNames = `action-button p-0 m-0 group mono text-xs leading-none flex items-center gap-2 rounded-sm border-solid border border-chalkboard-30 hover:border-chalkboard-40 enabled:dark:border-chalkboard-70 dark:hover:border-chalkboard-60 dark:bg-chalkboard-90/50 text-chalkboard-100 dark:text-chalkboard-10 ${
const classNames = `action-button leading-[0.7] p-0 m-0 group mono text-xs leading-none flex items-center gap-2 rounded-sm border-solid border border-chalkboard-30 hover:border-chalkboard-40 enabled:dark:border-chalkboard-70 dark:hover:border-chalkboard-60 dark:bg-chalkboard-90/50 text-chalkboard-100 dark:text-chalkboard-10 ${
props.iconStart
? props.iconEnd
? 'px-0' // No padding if both icons are present

2
src/components/ActionIcon.tsx
View File

@ -37,7 +37,7 @@ export const ActionIcon = (props: ActionIconProps) => {
const computedBgClassName = `bg-chalkboard-20 dark:bg-chalkboard-80 group-disabled:bg-chalkboard-30 dark:group-disabled:bg-chalkboard-80 ${bgClassName}`
return (
<span style={{ color: iconColor }}>
<span style={{ display: 'contents', color: iconColor }}>
<div
data-testid={props['data-testid']}
className={