ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

set Playwright actionTimeout to 15 seconds (#3115)

Browse Source 
* set playwright actionTimeout to 15 seconds

* enabled screenshot on failure and html reporter to easily see individual test duration

* extend timeout when waiting for console

* removed duplicated html reporter

---------

Co-authored-by: Kurt Hutten <k.hutten@protonmail.ch>
Co-authored-by: ryanrosello-og <ry@zoo.dev>
This commit is contained in:
ryanrosello-og
2024-08-08 09:19:07 +10:00
committed by GitHub
parent acfc2b47fa
commit 6773dbe7ff
2 changed files with 13 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
e2e/playwright/test-utils.ts
View File

@ -246,7 +246,8 @@ export const getMovementUtils = (opts: any) => {
} }
async function waitForAuthAndLsp(page: Page) { async function waitForAuthAndLsp(page: Page) {
const waitForLspPromise = page.waitForEvent('console', async (message) => { const waitForLspPromise = page.waitForEvent('console', {
predicate: async (message) => {
// it would be better to wait for a message that the kcl lsp has started by looking for the message message.text().includes('[lsp] [window/logMessage]') // it would be better to wait for a message that the kcl lsp has started by looking for the message message.text().includes('[lsp] [window/logMessage]')
// but that doesn't seem to make it to the console for macos/safari :( // but that doesn't seem to make it to the console for macos/safari :(
if (message.text().includes('start kcl lsp')) { if (message.text().includes('start kcl lsp')) {
@ -254,6 +255,8 @@ async function waitForAuthAndLsp(page: Page) {
return true return true
} }
return false return false
},
timeout: 45_000,
}) })
if (process.env.CI) { if (process.env.CI) {
await waitForPageLoadWithRetry(page) await waitForPageLoadWithRetry(page)

2
playwright.config.ts
View File

@ -32,6 +32,8 @@ export default defineConfig({
/* Collect trace when retrying the failed test. See https://playwright.dev/docs/trace-viewer */ /* Collect trace when retrying the failed test. See https://playwright.dev/docs/trace-viewer */
trace: 'retain-on-failure', trace: 'retain-on-failure',
actionTimeout: 15000,
screenshot: 'only-on-failure',
}, },
/* Configure projects for major browsers */ /* Configure projects for major browsers */