ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix edge case of sketch not being exited out of properly (#7396)

Browse Source 
* fix edge case of sketch not being exited out of properly

* Update e2e/playwright/sketch-tests.spec.ts

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

---------

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Co-authored-by: Jace Browning <jacebrowning@gmail.com>
This commit is contained in:
Kurt Hutten
2025-06-07 03:20:06 +10:00
committed by GitHub
parent 1fd4e93091
commit 6996670020
2 changed files with 80 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/machines/modelingMachine.ts
View File

@ -806,6 +806,20 @@ export const modelingMachine = setup({
toast.error(event.error.message)
}
},
toastErrorAndExitSketch: ({ event }) => {
if ('output' in event && event.output instanceof Error) {
toast.error(event.output.message)
} else if ('data' in event && event.data instanceof Error) {
toast.error(event.data.message)
} else if ('error' in event && event.error instanceof Error) {
toast.error(event.error.message)
}
// Clean up the THREE.js sketch scene
sceneEntitiesManager.tearDownSketch({ removeAxis: false })
sceneEntitiesManager.removeSketchGrid()
sceneEntitiesManager.resetOverlays()
},
'assign tool in context': assign({
currentTool: ({ event }) =>
event.type === 'change tool' ? event.data.tool || 'none' : 'none',
@ -4407,7 +4421,7 @@ export const modelingMachine = setup({
},
onError: {
target: '#Modeling.idle',
actions: 'toastError',
actions: 'toastErrorAndExitSketch',
reenter: true,
},
},