ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

KCL: Migrate hole to kwargs (#6382)

Browse Source 
Previously:

`|> hole(circle(radius = 2, center = p), %)`

Now:

`|> subtract2d(tool = circle(radius = 2, center = p))`
This commit is contained in:
Adam Chalmers
2025-04-26 15:31:51 -05:00
committed by GitHub
parent 5a18f551aa
commit 6e115c19d5
116 changed files with 12912 additions and 12847 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
rust/kcl-lib/src/docs/mod.rs
View File

@ -512,8 +512,8 @@ pub trait StdLibFn: std::fmt::Debug + Send + Sync {
return Ok("subtract([${0:extrude001}], tools = [${1:extrude002}])".to_string());
} else if self.name() == "intersect" {
return Ok("intersect([${0:extrude001}, ${1:extrude002}])".to_string());
} else if self.name() == "hole" {
return Ok("hole(${0:holeSketch}, ${1:%})".to_string());
} else if self.name() == "subtract2D" {
return Ok("subtract2d(${0:%}, tool = ${1:%})".to_string());
}
let in_keyword_fn = self.keyword_arguments();
let mut args = Vec::new();
@ -1015,9 +1015,9 @@ mod tests {
#[test]
fn get_autocomplete_snippet_hole() {
let hole_fn: Box<dyn StdLibFn> = Box::new(crate::std::sketch::Hole);
let snippet = hole_fn.to_autocomplete_snippet().unwrap();
assert_eq!(snippet, r#"hole(${0:holeSketch}, ${1:%})"#);
let f: Box<dyn StdLibFn> = Box::new(crate::std::sketch::Subtract2D);
let snippet = f.to_autocomplete_snippet().unwrap();
assert_eq!(snippet, r#"subtract2d(${0:%}, tool = ${1:%})"#);
}
#[test]