ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix tanArcTo (#3318)

Browse Source 
* updated tangentArc math

* Add a test case showing tan arc then xLineTo

* Fix compile errors

* Tweaking the math

* Use + on angles

* atan2 outputs radians, not degrees

* Track ccw and center of all tan arcs

* re-sequenced atan2 arcTan

* Remove print statements

* Update the test

* Update kittycad in tauri

* New arc fields

---------

Co-authored-by: Jordan Noone <jordan@kittycad.io>
This commit is contained in:
Adam Chalmers
2024-08-07 18:35:41 -05:00
committed by GitHub
parent 6773dbe7ff
commit 6f4bbdb79e
49 changed files with 2700 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
docs/kcl/arc.md
View File

@ -183,6 +183,10 @@ const exampleSketch = startSketchOn('XZ')
type: "TangentialArcTo",
} |
{
// arc's direction
ccw: string,
// the arc's center
center: [number, number],
// The from point.
from: [number, number],
// The tag of the path.
@ -388,6 +392,10 @@ const exampleSketch = startSketchOn('XZ')
type: "TangentialArcTo",
} |
{
// arc's direction
ccw: string,
// the arc's center
center: [number, number],
// The from point.
from: [number, number],
// The tag of the path.
@ -595,6 +603,10 @@ const exampleSketch = startSketchOn('XZ')
type: "TangentialArcTo",
} |
{
// arc's direction
ccw: string,
// the arc's center
center: [number, number],
// The from point.
from: [number, number],
// The tag of the path.
@ -800,6 +812,10 @@ const exampleSketch = startSketchOn('XZ')
type: "TangentialArcTo",
} |
{
// arc's direction
ccw: string,
// the arc's center
center: [number, number],
// The from point.
from: [number, number],
// The tag of the path.