From 75dff9f775a6e8a8fc43aa9e04bc59d0ecbb2c5f Mon Sep 17 00:00:00 2001 From: Jace Browning Date: Thu, 29 May 2025 12:35:02 -0400 Subject: [PATCH] Remove CI-only page load retry loop (#7272) Remove CI-only page load retry --- e2e/playwright/test-utils.ts | 24 ++---------------------- 1 file changed, 2 insertions(+), 22 deletions(-) diff --git a/e2e/playwright/test-utils.ts b/e2e/playwright/test-utils.ts index 1ca56a799..aa1e9ca08 100644 --- a/e2e/playwright/test-utils.ts +++ b/e2e/playwright/test-utils.ts @@ -79,20 +79,6 @@ export function runningOnWindows() { return process.platform === 'win32' } -async function waitForPageLoadWithRetry(page: Page) { - await expect(async () => { - await page.goto('/') - const errorMessage = 'App failed to load - 🔃 Retrying ...' - - await expect( - page.getByRole('button', { name: 'sketch Start Sketch' }), - errorMessage - ).toBeEnabled({ - timeout: 20_000, - }) - }).toPass({ timeout: 70_000, intervals: [1_000] }) -} - // lee: This needs to be replaced by scene.settled() eventually. async function waitForPageLoad(page: Page) { await expect(page.getByRole('button', { name: 'Start Sketch' })).toBeEnabled({ @@ -354,13 +340,8 @@ async function waitForAuthAndLsp(page: Page) { }, timeout: 45_000, }) - if (process.env.CI) { - await waitForPageLoadWithRetry(page) - } else { - await page.goto('/') - await waitForPageLoad(page) - } - + await page.goto('/') + await waitForPageLoad(page) return waitForLspPromise } @@ -391,7 +372,6 @@ export async function getUtils(page: Page, test_?: typeof test) { const util = { waitForAuthSkipAppStart: () => waitForAuthAndLsp(page), waitForPageLoad: () => waitForPageLoad(page), - waitForPageLoadWithRetry: () => waitForPageLoadWithRetry(page), removeCurrentCode: () => removeCurrentCode(page), sendCustomCmd: (cmd: EngineCommand) => sendCustomCmd(page, cmd), updateCamPosition: async (xyz: [number, number, number]) => {