diff --git a/.codespellrc b/.codespellrc index f3fb3ae79..63f506c1d 100644 --- a/.codespellrc +++ b/.codespellrc @@ -1,3 +1,3 @@ [codespell] ignore-words-list: crate,everytime,inout,co-ordinate,ot,nwo,atleast,ue,afterall,ser,fromM,FromM -skip: **/target,node_modules,build,dist,./out,**/Cargo.lock,./docs/kcl/*.md,.package-lock.json,**/package-lock.json,./openapi/*.json,./packages/codemirror-lang-kcl/test/all.test.ts,./public/kcl-samples,./rust/kcl-lib/tests/kcl_samples,tsconfig.tsbuildinfo,./src/lib/machine-api.d.ts +skip: **/target,node_modules,build,dist,./out,**/Cargo.lock,./docs/kcl/*.md,./e2e/playwright/lib/console-error-whitelist.ts,.package-lock.json,**/package-lock.json,./openapi/*.json,./packages/codemirror-lang-kcl/test/all.test.ts,./public/kcl-samples,./rust/kcl-lib/tests/kcl_samples,tsconfig.tsbuildinfo,./src/lib/machine-api.d.ts diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yml index 8726e2f31..0751fb7a8 100644 --- a/.github/workflows/e2e-tests.yml +++ b/.github/workflows/e2e-tests.yml @@ -226,8 +226,8 @@ jobs: with: shell: bash command: npm run test:snapshots - timeout_minutes: 30 - max_attempts: 3 + timeout_minutes: 5 + max_attempts: 5 env: token: ${{ secrets.KITTYCAD_API_TOKEN_DEV }} snapshottoken: ${{ secrets.KITTYCAD_API_TOKEN }} diff --git a/e2e/playwright/lib/console-error-whitelist.ts b/e2e/playwright/lib/console-error-whitelist.ts index d0a27ea83..857506cc3 100644 --- a/e2e/playwright/lib/console-error-whitelist.ts +++ b/e2e/playwright/lib/console-error-whitelist.ts @@ -63,6 +63,16 @@ export const isErrorWhitelisted = (exception: Error) => { 'e2e/playwright/can-create-sketches-on-all-planes-and-their-back-sides.spec.ts XY', project: 'Google Chrome', }, + { + name: '', + message: 'fE', + stack: ` + at ET (file:///Users/runner/work/modeling-app/modeling-app/.vite/renderer/main_window/assets/index-DduzBCVE.js:49875:12) + at HGe.clearSceneAndBustCache (file:///Users/runner/work/modeling-app/modeling-app/.vite/renderer/main_window/assets/index-DduzBCVE.js:91941:19) + at async a.onEngineConnectionOpened (file:///Users/runner/work/modeling-app/modeling-app/.vite/renderer/main_window/assets/index-DduzBCVE.js:91538:9)`, + foundInSpec: 'e2e/playwright/testing-constraints.spec.ts', + project: 'Google Chrome', + }, { name: 'RangeError', message: 'Position 160 is out of range for changeset of length 0', diff --git a/e2e/playwright/snapshot-tests.spec.ts b/e2e/playwright/snapshot-tests.spec.ts index c0d65405b..57e287740 100644 --- a/e2e/playwright/snapshot-tests.spec.ts +++ b/e2e/playwright/snapshot-tests.spec.ts @@ -805,8 +805,7 @@ test( 'Sketch on face with none z-up', { tag: '@snapshot' }, async ({ page, context, cmdBar, scene }) => { - // FIXME: Skip on macos its being weird. - test.skip(process.platform === 'darwin', 'Skip on macos') + test.fixme(orRunWhenFullSuiteEnabled()) const u = await getUtils(page) await context.addInitScript(async (KCL_DEFAULT_LENGTH) => { @@ -1137,6 +1136,7 @@ test('theme persists', async ({ page, context }) => { test.describe('code color goober', { tag: '@snapshot' }, () => { test('code color goober', async ({ page, context, scene, cmdBar }) => { + test.fixme(orRunWhenFullSuiteEnabled()) const u = await getUtils(page) await context.addInitScript(async () => { localStorage.setItem(