settings/auth outermost (#2099)

* settings/auth outermost Signed-off-by: Jess Frazelle <github@jessfraz.com> * fmt Signed-off-by: Jess Frazelle <github@jessfraz.com> --------- Signed-off-by: Jess Frazelle <github@jessfraz.com>
2024-04-12 14:30:00 -07:00
parent 63be31971f
commit 82bad2cab1
1 changed files with 8 additions and 6 deletions
--- a/src/Router.tsx
+++ b/src/Router.tsx
@ -35,15 +35,17 @@ const router = createBrowserRouter([
  {
    loader: settingsLoader,
    id: paths.INDEX,
+    /* Make sure auth is the outermost provider or else we will have
+     * inefficient re-renders, use the react profiler to see. */
    element: (
      <CommandBarProvider>
-        <KclContextProvider>
-          <SettingsAuthProvider>
-            <LspProvider>
+        <SettingsAuthProvider>
+          <LspProvider>
+            <KclContextProvider>
              <Outlet />
-            </LspProvider>
-          </SettingsAuthProvider>
-        </KclContextProvider>
+            </KclContextProvider>
+          </LspProvider>
+        </SettingsAuthProvider>
      </CommandBarProvider>
    ),
    errorElement: <ErrorPage />,