ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make onboarding optional, able to be ignored on desktop (take 2) (#6628)

Browse Source 
* Remove unused `telemetryLoader`

* Remove onboarding redirect behavior

* Allow subRoute to be passed to navigateToProject

* Replace warning dialog routes with toasts

* Wire up new utilities and toasts to UI components

* Add home sidebar buttons for tutorial flow

* Rename menu item

* Add flex-1 so home-layout fills available space

* Remove onboarding avatar tests, they are becoming irrelevant

* Consolidate onboarding tests to one longer one

and update it to not use pixel color checks, and use fixtures.

* Shorten warning toast button text

* tsc, lint, and circular deps

* Update circular dep file

* Fix mistakes made in circular update tweaking

* One more dumb created circular dep

* Update src/routes/Onboarding/utils.tsx

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>

* Fix narrow screen home layout breaking

* fix: kevin, navigation routes fixed

* fix: filename parsing is correct now for onboarding with the last file sep

* Fix e2e test state checks that are diff on Linux

* Create onboarding project entirely through systemIOMachine

* Fix Windows path construction

* Make utility to verify a string is an onboarding value

* Little biome formatting suggestion fix

* Units onboarding step was not using OnboardingButtons

* Add type checking of next and previous status, fix useNextClick

* Thanks Graphite Diamond, I should use that new util

* Remove TODO comment

* Fix botched merge because IS_PLAYWRIGHT moved or something

---------

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Co-authored-by: Kevin Nadro <kevin@zoo.dev>
This commit is contained in:
Frank Noirot
2025-05-02 15:54:49 -04:00
committed by GitHub
parent 00553c34ab
commit 86a83cadd3
46 changed files with 859 additions and 1069 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
e2e/playwright/native-file-menu.spec.ts
View File

@ -450,7 +450,7 @@ test.describe(
)
await expect(actual).toBeVisible()
})
test('Home.Help.Reset onboarding', async ({
test('Home.Help.Replay onboarding tutorial', async ({
tronApp,
cmdBar,
page,
@ -464,7 +464,7 @@ test.describe(
await tronApp.electron.evaluate(async ({ app }) => {
if (!app || !app.applicationMenu) return false
const menu = app.applicationMenu.getMenuItemById(
'Help.Reset onboarding'
'Help.Replay onboarding tutorial'
)
if (!menu) {
return false
@ -2339,7 +2339,7 @@ test.describe(
await scene.connectionEstablished()
await expect(toolbar.startSketchBtn).toBeVisible()
})
test('Modeling.Help.Reset onboarding', async ({
test('Modeling.Help.Replay onboarding tutorial', async ({
tronApp,
cmdBar,
page,
@ -2358,7 +2358,7 @@ test.describe(
await tronApp.electron.evaluate(async ({ app }) => {
if (!app || !app.applicationMenu) fail()
const menu = app.applicationMenu.getMenuItemById(
'Help.Reset onboarding'
'Help.Replay onboarding tutorial'
)
if (!menu) fail()
menu.click()