Fix: Ignore KCL changes when loading settings and fixed useEffect to use .current (#5126)

* fix: fixed use effect logic to use .current, fixed useEffect file watcher to not watch .kcl files when loading settings

* A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores)

* A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores)

* A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores)

* bump

* A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores)

* bump

* A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores)

* bump

* A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubuntu-8-cores)

* fix: merge wrote this back...

* fix: deleted unused variable init

* A snapshot a day keeps the bugs away! 📷🐛

* A snapshot a day keeps the bugs away! 📷🐛

* A snapshot a day keeps the bugs away! 📷🐛

* bump

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Pierre Jacquier <pierre@zoo.dev>
This commit is contained in:
Kevin Nadro
2025-03-24 18:23:12 -05:00
committed by GitHub
parent 7c9f1248d4
commit 8c3408fda3
5 changed files with 1 additions and 12 deletions

Binary file not shown.

Before

Width:  |  Height:  |  Size: 75 KiB

After

Width:  |  Height:  |  Size: 75 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 69 KiB

After

Width:  |  Height:  |  Size: 69 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 72 KiB

After

Width:  |  Height:  |  Size: 72 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 68 KiB

After

Width:  |  Height:  |  Size: 68 KiB

View File

@ -148,7 +148,6 @@ export const ModelingMachineProvider = ({
enableSSAO, enableSSAO,
}, },
} = useSettings() } = useSettings()
const previousAllowOrbitInSketchMode = useRef(allowOrbitInSketchMode.current)
const navigate = useNavigate() const navigate = useNavigate()
const { context, send: fileMachineSend } = useFileContext() const { context, send: fileMachineSend } = useFileContext()
const { file } = useLoaderData() as IndexLoaderData const { file } = useLoaderData() as IndexLoaderData
@ -1841,14 +1840,6 @@ export const ModelingMachineProvider = ({
}, [engineCommandManager.engineConnection, modelingSend]) }, [engineCommandManager.engineConnection, modelingSend])
useEffect(() => { useEffect(() => {
// Only trigger this if the state actually changes, if it stays the same do not reload the camera
if (
previousAllowOrbitInSketchMode.current === allowOrbitInSketchMode.current
) {
//no op
previousAllowOrbitInSketchMode.current = allowOrbitInSketchMode.current
return
}
const inSketchMode = modelingState.matches('Sketch') const inSketchMode = modelingState.matches('Sketch')
// If you are in sketch mode and you disable the orbit, return back to the normal view to the target // If you are in sketch mode and you disable the orbit, return back to the normal view to the target
@ -1871,9 +1862,7 @@ export const ModelingMachineProvider = ({
if (inSketchMode) { if (inSketchMode) {
sceneInfra.camControls.enableRotate = allowOrbitInSketchMode.current sceneInfra.camControls.enableRotate = allowOrbitInSketchMode.current
} }
}, [allowOrbitInSketchMode.current])
previousAllowOrbitInSketchMode.current = allowOrbitInSketchMode.current
}, [allowOrbitInSketchMode])
// Allow using the delete key to delete solids. Backspace only on macOS as Windows and Linux have dedicated Delete // Allow using the delete key to delete solids. Backspace only on macOS as Windows and Linux have dedicated Delete
// `navigator.platform` is deprecated, but the alternative `navigator.userAgentData.platform` is not reliable // `navigator.platform` is deprecated, but the alternative `navigator.userAgentData.platform` is not reliable