ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

getCommonEdge as default way of filleting (#6043)

Browse Source 
* Common edge faces into artifact graph

* clean up

* kingdom of tags

* add tests

* hook up tags with edge treatments

* update unit tests

* update e2e

* clean up

* more fix up after main merge

* fmt

* revolve fix

* fix new circular dependency

* fix revolve

* remove numbers from circ deps, makes diffs bad

* sim test updates

* try and get tests working

* update

* Fix tsc error

---------

Co-authored-by: max-mrgrsk <156543465+max-mrgrsk@users.noreply.github.com>
Co-authored-by: max <margorskyi@gmail.com>
Co-authored-by: Jonathan Tran <jonnytran@gmail.com>
This commit is contained in:
Kurt Hutten
2025-04-26 14:00:28 +10:00
committed by GitHub
parent 50f8131d83
commit 8de648f0db
224 changed files with 157661 additions and 42680 deletions
Download Patch File Download Diff File Expand all files Collapse all files

309
rust/kcl-lib/tests/kcl_samples/ball-bearing/artifact_commands.snap
View File

@ -309,6 +309,33 @@ description: Artifact commands ball-bearing.kcl
"face_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
@ -329,6 +356,33 @@ description: Artifact commands ball-bearing.kcl
"face_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
@ -492,6 +546,33 @@ description: Artifact commands ball-bearing.kcl
"face_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
@ -512,6 +593,33 @@ description: Artifact commands ball-bearing.kcl
"face_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
@ -734,20 +842,27 @@ description: Artifact commands ball-bearing.kcl
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_opposite_edge",
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]",
"face_id": "[uuid]"
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_next_adjacent_edge",
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]",
"face_id": "[uuid]"
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]"
}
},
{
@ -770,6 +885,33 @@ description: Artifact commands ball-bearing.kcl
"face_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
@ -790,6 +932,80 @@ description: Artifact commands ball-bearing.kcl
"face_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_opposite_edge",
"object_id": "[uuid]",
"edge_id": "[uuid]",
"face_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_next_adjacent_edge",
"object_id": "[uuid]",
"edge_id": "[uuid]",
"face_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
@ -974,6 +1190,33 @@ description: Artifact commands ball-bearing.kcl
"face_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
@ -1275,6 +1518,33 @@ description: Artifact commands ball-bearing.kcl
"face_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
@ -1295,6 +1565,33 @@ description: Artifact commands ball-bearing.kcl
"face_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],
"command": {
"type": "solid3d_get_all_edge_faces",
"object_id": "[uuid]",
"edge_id": "[uuid]"
}
},
{
"cmdId": "[uuid]",
"range": [],

223
rust/kcl-lib/tests/kcl_samples/ball-bearing/artifact_graph_flowchart.snap.md
View File

@ -10,156 +10,123 @@ flowchart LR
6["Segment<br>[737, 783, 0]"]
7[Solid2d]
end
subgraph path15 [Path]
15["Path<br>[970, 1026, 0]"]
16["Segment<br>[1032, 1091, 0]"]
17["Segment<br>[1097, 1104, 0]"]
18[Solid2d]
subgraph path13 [Path]
13["Path<br>[970, 1026, 0]"]
14["Segment<br>[1032, 1091, 0]"]
15["Segment<br>[1097, 1104, 0]"]
16[Solid2d]
end
subgraph path24 [Path]
24["Path<br>[1474, 1607, 0]"]
25["Segment<br>[1613, 1673, 0]"]
26["Segment<br>[1679, 1710, 0]"]
27["Segment<br>[1716, 1744, 0]"]
28["Segment<br>[1750, 1757, 0]"]
29[Solid2d]
subgraph path21 [Path]
21["Path<br>[1474, 1607, 0]"]
22["Segment<br>[1613, 1673, 0]"]
23["Segment<br>[1679, 1710, 0]"]
24["Segment<br>[1716, 1744, 0]"]
25["Segment<br>[1750, 1757, 0]"]
26[Solid2d]
end
subgraph path40 [Path]
40["Path<br>[2091, 2233, 0]"]
41["Segment<br>[2091, 2233, 0]"]
42[Solid2d]
subgraph path33 [Path]
33["Path<br>[2091, 2233, 0]"]
34["Segment<br>[2091, 2233, 0]"]
35[Solid2d]
end
subgraph path50 [Path]
50["Path<br>[2627, 2680, 0]"]
51["Segment<br>[2627, 2680, 0]"]
52[Solid2d]
subgraph path41 [Path]
41["Path<br>[2627, 2680, 0]"]
42["Segment<br>[2627, 2680, 0]"]
43[Solid2d]
end
subgraph path53 [Path]
53["Path<br>[2691, 2765, 0]"]
54["Segment<br>[2691, 2765, 0]"]
55[Solid2d]
subgraph path44 [Path]
44["Path<br>[2691, 2765, 0]"]
45["Segment<br>[2691, 2765, 0]"]
46[Solid2d]
end
1["Plane<br>[610, 657, 0]"]
8["Sweep Extrusion<br>[838, 890, 0]"]
9[Wall]
10["Cap Start"]
11["Cap End"]
12["SweepEdge Opposite"]
13["SweepEdge Adjacent"]
14["Plane<br>[947, 964, 0]"]
19["Sweep Revolve<br>[1186, 1216, 0]"]
20[Wall]
21[Wall]
22["SweepEdge Adjacent"]
23["Plane<br>[1451, 1468, 0]"]
30["Sweep Revolve<br>[1799, 1829, 0]"]
12["Plane<br>[947, 964, 0]"]
17["Sweep Revolve<br>[1186, 1216, 0]"]
18[Wall]
19[Wall]
20["Plane<br>[1451, 1468, 0]"]
27["Sweep Revolve<br>[1799, 1829, 0]"]
28[Wall]
29[Wall]
30[Wall]
31[Wall]
32[Wall]
33[Wall]
34[Wall]
35["SweepEdge Adjacent"]
36["SweepEdge Adjacent"]
37["SweepEdge Adjacent"]
38["SweepEdge Adjacent"]
39["Plane<br>[2068, 2085, 0]"]
43["Sweep Revolve<br>[2276, 2327, 0]"]
44[Wall]
45["Cap Start"]
46["Cap End"]
47["SweepEdge Opposite"]
48["SweepEdge Adjacent"]
49["Plane<br>[2573, 2620, 0]"]
56["Sweep Extrusion<br>[2785, 2838, 0]"]
57[Wall]
58["Cap Start"]
59["Cap End"]
60["SweepEdge Opposite"]
61["SweepEdge Adjacent"]
62["StartSketchOnPlane<br>[596, 658, 0]"]
63["StartSketchOnPlane<br>[2559, 2621, 0]"]
32["Plane<br>[2068, 2085, 0]"]
36["Sweep Revolve<br>[2276, 2327, 0]"]
37[Wall]
38["Cap Start"]
39["Cap End"]
40["Plane<br>[2573, 2620, 0]"]
47["Sweep Extrusion<br>[2785, 2838, 0]"]
48[Wall]
49["Cap Start"]
50["Cap End"]
51["StartSketchOnPlane<br>[596, 658, 0]"]
52["StartSketchOnPlane<br>[2559, 2621, 0]"]
1 --- 2
1 --- 5
2 --- 3
2 ---- 8
2 --- 4
3 --- 9
3 --- 12
3 --- 13
3 x--> 10
5 --- 6
5 --- 7
8 --- 9
8 --- 10
8 --- 11
8 --- 12
8 --- 13
14 --- 15
15 --- 16
15 --- 17
15 ---- 19
15 --- 18
16 --- 20
16 x--> 22
17 --- 21
17 --- 22
19 --- 20
19 --- 21
19 <--x 16
19 --- 22
19 <--x 17
23 --- 24
24 --- 25
24 --- 26
24 --- 27
24 --- 28
24 ---- 30
24 --- 29
12 --- 13
13 --- 14
13 --- 15
13 ---- 17
13 --- 16
14 --- 18
15 --- 19
17 --- 18
17 --- 19
17 <--x 15
20 --- 21
21 --- 22
21 --- 23
21 --- 24
21 --- 25
21 ---- 27
21 --- 26
22 --- 28
23 --- 29
24 --- 30
25 --- 31
25 --- 35
26 --- 32
26 --- 36
27 --- 33
27 --- 37
28 --- 34
28 --- 38
30 --- 31
30 --- 32
30 --- 33
30 --- 34
30 <--x 25
30 --- 35
30 <--x 26
30 --- 36
30 <--x 27
30 --- 37
30 <--x 28
30 --- 38
39 --- 40
27 --- 28
27 --- 29
27 --- 30
27 --- 31
27 <--x 23
27 <--x 24
27 <--x 25
32 --- 33
33 --- 34
33 ---- 36
33 --- 35
34 --- 37
34 x--> 38
36 --- 37
36 --- 38
36 --- 39
40 --- 41
40 ---- 43
40 --- 42
41 --- 44
41 --- 47
41 --- 48
43 --- 44
43 --- 45
43 --- 46
43 --- 47
43 --- 48
49 --- 50
49 --- 53
50 --- 51
50 ---- 56
50 --- 52
51 --- 57
51 --- 60
51 --- 61
53 --- 54
53 --- 55
56 --- 57
56 --- 58
56 --- 59
56 --- 60
56 --- 61
1 <--x 62
49 <--x 63
40 --- 44
41 --- 42
41 ---- 47
41 --- 43
42 --- 48
42 x--> 49
44 --- 45
44 --- 46
47 --- 48
47 --- 49
47 --- 50
1 <--x 51
40 <--x 52
```