ByoungSooPark/modeling-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

getCommonEdge as default way of filleting (#6043)

Browse Source 
* Common edge faces into artifact graph

* clean up

* kingdom of tags

* add tests

* hook up tags with edge treatments

* update unit tests

* update e2e

* clean up

* more fix up after main merge

* fmt

* revolve fix

* fix new circular dependency

* fix revolve

* remove numbers from circ deps, makes diffs bad

* sim test updates

* try and get tests working

* update

* Fix tsc error

---------

Co-authored-by: max-mrgrsk <156543465+max-mrgrsk@users.noreply.github.com>
Co-authored-by: max <margorskyi@gmail.com>
Co-authored-by: Jonathan Tran <jonnytran@gmail.com>
This commit is contained in:
Kurt Hutten
2025-04-26 14:00:28 +10:00
committed by GitHub
parent 50f8131d83
commit 8de648f0db
224 changed files with 157661 additions and 42680 deletions
Download Patch File Download Diff File Expand all files Collapse all files

840
rust/kcl-lib/tests/kcl_samples/enclosure/artifact_commands.snap
View File

File diff suppressed because it is too large Load Diff

603
rust/kcl-lib/tests/kcl_samples/enclosure/artifact_graph_flowchart.snap.md
View File

@ -9,103 +9,103 @@ flowchart LR
7["Segment<br>[709, 716, 0]"]
8[Solid2d]
end
subgraph path29 [Path]
29["Path<br>[1597, 1680, 0]"]
30["Segment<br>[1597, 1680, 0]"]
31[Solid2d]
subgraph path25 [Path]
25["Path<br>[1597, 1680, 0]"]
26["Segment<br>[1597, 1680, 0]"]
27[Solid2d]
end
subgraph path32 [Path]
32["Path<br>[1693, 1760, 0]"]
33["Segment<br>[1693, 1760, 0]"]
34[Solid2d]
subgraph path28 [Path]
28["Path<br>[1693, 1760, 0]"]
29["Segment<br>[1693, 1760, 0]"]
30[Solid2d]
end
subgraph path42 [Path]
42["Path<br>[1597, 1680, 0]"]
43["Segment<br>[1597, 1680, 0]"]
44[Solid2d]
subgraph path36 [Path]
36["Path<br>[1597, 1680, 0]"]
37["Segment<br>[1597, 1680, 0]"]
38[Solid2d]
end
subgraph path45 [Path]
45["Path<br>[1693, 1760, 0]"]
46["Segment<br>[1693, 1760, 0]"]
47[Solid2d]
subgraph path39 [Path]
39["Path<br>[1693, 1760, 0]"]
40["Segment<br>[1693, 1760, 0]"]
41[Solid2d]
end
subgraph path55 [Path]
55["Path<br>[1597, 1680, 0]"]
56["Segment<br>[1597, 1680, 0]"]
57[Solid2d]
subgraph path47 [Path]
47["Path<br>[1597, 1680, 0]"]
48["Segment<br>[1597, 1680, 0]"]
49[Solid2d]
end
subgraph path50 [Path]
50["Path<br>[1693, 1760, 0]"]
51["Segment<br>[1693, 1760, 0]"]
52[Solid2d]
end
subgraph path58 [Path]
58["Path<br>[1693, 1760, 0]"]
59["Segment<br>[1693, 1760, 0]"]
58["Path<br>[1597, 1680, 0]"]
59["Segment<br>[1597, 1680, 0]"]
60[Solid2d]
end
subgraph path68 [Path]
68["Path<br>[1597, 1680, 0]"]
69["Segment<br>[1597, 1680, 0]"]
70[Solid2d]
subgraph path61 [Path]
61["Path<br>[1693, 1760, 0]"]
62["Segment<br>[1693, 1760, 0]"]
63[Solid2d]
end
subgraph path71 [Path]
71["Path<br>[1693, 1760, 0]"]
72["Segment<br>[1693, 1760, 0]"]
73[Solid2d]
subgraph path69 [Path]
69["Path<br>[2331, 2366, 0]"]
70["Segment<br>[2372, 2438, 0]"]
71["Segment<br>[2444, 2543, 0]"]
72["Segment<br>[2549, 2666, 0]"]
73["Segment<br>[2672, 2757, 0]"]
74["Segment<br>[2763, 2770, 0]"]
75[Solid2d]
end
subgraph path81 [Path]
81["Path<br>[2331, 2366, 0]"]
82["Segment<br>[2372, 2438, 0]"]
83["Segment<br>[2444, 2543, 0]"]
84["Segment<br>[2549, 2666, 0]"]
85["Segment<br>[2672, 2757, 0]"]
86["Segment<br>[2763, 2770, 0]"]
subgraph path76 [Path]
76["Path<br>[2781, 2937, 0]"]
77["Segment<br>[2781, 2937, 0]"]
78[Solid2d]
end
subgraph path79 [Path]
79["Path<br>[2952, 3119, 0]"]
80["Segment<br>[2952, 3119, 0]"]
81[Solid2d]
end
subgraph path82 [Path]
82["Path<br>[3134, 3292, 0]"]
83["Segment<br>[3134, 3292, 0]"]
84[Solid2d]
end
subgraph path85 [Path]
85["Path<br>[3307, 3476, 0]"]
86["Segment<br>[3307, 3476, 0]"]
87[Solid2d]
end
subgraph path88 [Path]
88["Path<br>[2781, 2937, 0]"]
89["Segment<br>[2781, 2937, 0]"]
90[Solid2d]
subgraph path103 [Path]
103["Path<br>[3922, 4006, 0]"]
104["Segment<br>[4012, 4100, 0]"]
105["Segment<br>[4106, 4227, 0]"]
106["Segment<br>[4233, 4350, 0]"]
107["Segment<br>[4356, 4441, 0]"]
108["Segment<br>[4447, 4454, 0]"]
109[Solid2d]
end
subgraph path91 [Path]
91["Path<br>[2952, 3119, 0]"]
92["Segment<br>[2952, 3119, 0]"]
93[Solid2d]
subgraph path110 [Path]
110["Path<br>[4465, 4637, 0]"]
111["Segment<br>[4465, 4637, 0]"]
112[Solid2d]
end
subgraph path94 [Path]
94["Path<br>[3134, 3292, 0]"]
95["Segment<br>[3134, 3292, 0]"]
96[Solid2d]
subgraph path113 [Path]
113["Path<br>[4652, 4835, 0]"]
114["Segment<br>[4652, 4835, 0]"]
115[Solid2d]
end
subgraph path97 [Path]
97["Path<br>[3307, 3476, 0]"]
98["Segment<br>[3307, 3476, 0]"]
99[Solid2d]
subgraph path116 [Path]
116["Path<br>[4850, 5024, 0]"]
117["Segment<br>[4850, 5024, 0]"]
118[Solid2d]
end
subgraph path119 [Path]
119["Path<br>[3922, 4006, 0]"]
120["Segment<br>[4012, 4100, 0]"]
121["Segment<br>[4106, 4227, 0]"]
122["Segment<br>[4233, 4350, 0]"]
123["Segment<br>[4356, 4441, 0]"]
124["Segment<br>[4447, 4454, 0]"]
125[Solid2d]
end
subgraph path126 [Path]
126["Path<br>[4465, 4637, 0]"]
127["Segment<br>[4465, 4637, 0]"]
128[Solid2d]
end
subgraph path129 [Path]
129["Path<br>[4652, 4835, 0]"]
130["Segment<br>[4652, 4835, 0]"]
131[Solid2d]
end
subgraph path132 [Path]
132["Path<br>[4850, 5024, 0]"]
133["Segment<br>[4850, 5024, 0]"]
134[Solid2d]
end
subgraph path135 [Path]
135["Path<br>[5039, 5224, 0]"]
136["Segment<br>[5039, 5224, 0]"]
137[Solid2d]
119["Path<br>[5039, 5224, 0]"]
120["Segment<br>[5039, 5224, 0]"]
121[Solid2d]
end
1["Plane<br>[264, 281, 0]"]
9["Sweep Extrusion<br>[730, 765, 0]"]
@ -116,85 +116,65 @@ flowchart LR
14["Cap Start"]
15["Cap End"]
16["SweepEdge Opposite"]
17["SweepEdge Adjacent"]
17["SweepEdge Opposite"]
18["SweepEdge Opposite"]
19["SweepEdge Adjacent"]
20["SweepEdge Opposite"]
21["SweepEdge Adjacent"]
22["SweepEdge Opposite"]
23["SweepEdge Adjacent"]
24["EdgeCut Fillet<br>[771, 1053, 0]"]
25["EdgeCut Fillet<br>[771, 1053, 0]"]
26["EdgeCut Fillet<br>[771, 1053, 0]"]
27["EdgeCut Fillet<br>[771, 1053, 0]"]
28["Plane<br>[1566, 1589, 0]"]
35["Sweep Extrusion<br>[1780, 1831, 0]"]
36[Wall]
37["Cap Start"]
38["Cap End"]
39["SweepEdge Opposite"]
40["SweepEdge Adjacent"]
41["Plane<br>[1566, 1589, 0]"]
48["Sweep Extrusion<br>[1780, 1831, 0]"]
49[Wall]
50["Cap Start"]
51["Cap End"]
52["SweepEdge Opposite"]
53["SweepEdge Adjacent"]
54["Plane<br>[1566, 1589, 0]"]
61["Sweep Extrusion<br>[1780, 1831, 0]"]
62[Wall]
63["Cap Start"]
64["Cap End"]
65["SweepEdge Opposite"]
66["SweepEdge Adjacent"]
67["Plane<br>[1566, 1589, 0]"]
74["Sweep Extrusion<br>[1780, 1831, 0]"]
75[Wall]
76["Cap Start"]
77["Cap End"]
78["SweepEdge Opposite"]
79["SweepEdge Adjacent"]
80["Plane<br>[2308, 2325, 0]"]
100["Sweep Extrusion<br>[3494, 3536, 0]"]
101[Wall]
102[Wall]
103[Wall]
104[Wall]
105["Cap Start"]
106["Cap End"]
107["SweepEdge Opposite"]
108["SweepEdge Adjacent"]
109["SweepEdge Opposite"]
110["SweepEdge Adjacent"]
111["SweepEdge Opposite"]
112["SweepEdge Adjacent"]
113["SweepEdge Opposite"]
114["SweepEdge Adjacent"]
115["EdgeCut Fillet<br>[3542, 3824, 0]"]
116["EdgeCut Fillet<br>[3542, 3824, 0]"]
117["EdgeCut Fillet<br>[3542, 3824, 0]"]
118["EdgeCut Fillet<br>[3542, 3824, 0]"]
138["Sweep Extrusion<br>[5242, 5284, 0]"]
139[Wall]
140[Wall]
141[Wall]
142[Wall]
143["Cap Start"]
144["Cap End"]
145["SweepEdge Opposite"]
146["SweepEdge Adjacent"]
147["SweepEdge Opposite"]
148["SweepEdge Adjacent"]
149["SweepEdge Opposite"]
150["SweepEdge Adjacent"]
151["SweepEdge Opposite"]
152["SweepEdge Adjacent"]
153["EdgeCut Fillet<br>[5290, 5572, 0]"]
154["EdgeCut Fillet<br>[5290, 5572, 0]"]
155["EdgeCut Fillet<br>[5290, 5572, 0]"]
156["EdgeCut Fillet<br>[5290, 5572, 0]"]
157["StartSketchOnFace<br>[3879, 3916, 0]"]
20["EdgeCut Fillet<br>[771, 1053, 0]"]
21["EdgeCut Fillet<br>[771, 1053, 0]"]
22["EdgeCut Fillet<br>[771, 1053, 0]"]
23["EdgeCut Fillet<br>[771, 1053, 0]"]
24["Plane<br>[1566, 1589, 0]"]
31["Sweep Extrusion<br>[1780, 1831, 0]"]
32[Wall]
33["Cap Start"]
34["Cap End"]
35["Plane<br>[1566, 1589, 0]"]
42["Sweep Extrusion<br>[1780, 1831, 0]"]
43[Wall]
44["Cap Start"]
45["Cap End"]
46["Plane<br>[1566, 1589, 0]"]
53["Sweep Extrusion<br>[1780, 1831, 0]"]
54[Wall]
55["Cap Start"]
56["Cap End"]
57["Plane<br>[1566, 1589, 0]"]
64["Sweep Extrusion<br>[1780, 1831, 0]"]
65[Wall]
66["Cap Start"]
67["Cap End"]
68["Plane<br>[2308, 2325, 0]"]
88["Sweep Extrusion<br>[3494, 3536, 0]"]
89[Wall]
90[Wall]
91[Wall]
92[Wall]
93["Cap Start"]
94["Cap End"]
95["SweepEdge Opposite"]
96["SweepEdge Opposite"]
97["SweepEdge Opposite"]
98["SweepEdge Adjacent"]
99["EdgeCut Fillet<br>[3542, 3824, 0]"]
100["EdgeCut Fillet<br>[3542, 3824, 0]"]
101["EdgeCut Fillet<br>[3542, 3824, 0]"]
102["EdgeCut Fillet<br>[3542, 3824, 0]"]
122["Sweep Extrusion<br>[5242, 5284, 0]"]
123[Wall]
124[Wall]
125[Wall]
126[Wall]
127["Cap Start"]
128["Cap End"]
129["SweepEdge Opposite"]
130["SweepEdge Opposite"]
131["SweepEdge Opposite"]
132["SweepEdge Adjacent"]
133["EdgeCut Fillet<br>[5290, 5572, 0]"]
134["EdgeCut Fillet<br>[5290, 5572, 0]"]
135["EdgeCut Fillet<br>[5290, 5572, 0]"]
136["EdgeCut Fillet<br>[5290, 5572, 0]"]
137["StartSketchOnFace<br>[3879, 3916, 0]"]
1 --- 2
2 --- 3
2 --- 4
@ -204,17 +184,17 @@ flowchart LR
2 ---- 9
2 --- 8
3 --- 10
3 --- 16
3 --- 17
3 --- 19
3 x--> 14
4 --- 11
4 --- 18
4 --- 19
4 --- 16
4 x--> 14
5 --- 12
5 --- 20
5 --- 21
5 --- 17
5 x--> 14
6 --- 13
6 --- 22
6 --- 23
6 --- 18
6 x--> 14
9 --- 10
9 --- 11
9 --- 12
@ -225,173 +205,158 @@ flowchart LR
9 --- 17
9 --- 18
9 --- 19
9 --- 20
9 --- 21
9 --- 22
9 --- 23
17 <--x 24
19 <--x 25
21 <--x 26
23 <--x 27
16 <--x 11
16 <--x 15
17 <--x 12
17 <--x 15
18 <--x 13
18 <--x 15
19 <--x 20
24 --- 25
24 --- 28
25 --- 26
25 ---- 31
25 --- 27
26 --- 32
26 x--> 33
28 --- 29
28 --- 32
29 --- 30
29 ---- 35
29 --- 31
30 --- 36
30 --- 39
30 --- 40
32 --- 33
32 --- 34
28 --- 30
31 --- 32
31 --- 33
31 --- 34
35 --- 36
35 --- 37
35 --- 38
35 --- 39
35 --- 40
41 --- 42
41 --- 45
36 --- 37
36 ---- 42
36 --- 38
37 --- 43
37 x--> 44
39 --- 40
39 --- 41
42 --- 43
42 ---- 48
42 --- 44
43 --- 49
43 --- 52
43 --- 53
45 --- 46
45 --- 47
48 --- 49
48 --- 50
48 --- 51
48 --- 52
48 --- 53
54 --- 55
54 --- 58
55 --- 56
55 ---- 61
55 --- 57
56 --- 62
56 --- 65
56 --- 66
42 --- 45
46 --- 47
46 --- 50
47 --- 48
47 ---- 53
47 --- 49
48 --- 54
48 x--> 55
50 --- 51
50 --- 52
53 --- 54
53 --- 55
53 --- 56
57 --- 58
57 --- 61
58 --- 59
58 ---- 64
58 --- 60
59 --- 65
59 x--> 66
61 --- 62
61 --- 63
61 --- 64
61 --- 65
61 --- 66
67 --- 68
67 --- 71
64 --- 65
64 --- 66
64 --- 67
68 --- 69
68 ---- 74
68 --- 70
68 --- 76
68 --- 79
68 --- 82
68 --- 85
69 --- 70
69 --- 71
69 --- 72
69 --- 73
69 --- 74
69 ---- 88
69 --- 75
69 --- 78
69 --- 79
71 --- 72
71 --- 73
74 --- 75
74 --- 76
74 --- 77
74 --- 78
74 --- 79
80 --- 81
80 --- 88
80 --- 91
80 --- 94
80 --- 97
81 --- 82
81 --- 83
81 --- 84
81 --- 85
81 --- 86
81 ---- 100
81 --- 87
82 --- 101
82 --- 107
82 --- 108
83 --- 102
83 --- 109
83 --- 110
84 --- 103
84 --- 111
84 --- 112
85 --- 104
85 --- 113
85 --- 114
70 --- 89
70 --- 98
70 x--> 93
71 --- 90
71 --- 95
71 x--> 93
72 --- 91
72 --- 96
72 x--> 93
73 --- 92
73 --- 97
73 x--> 93
76 --- 77
76 --- 78
79 --- 80
79 --- 81
82 --- 83
82 --- 84
85 --- 86
85 --- 87
88 --- 89
88 --- 90
91 --- 92
91 --- 93
94 --- 95
94 --- 96
97 --- 98
97 --- 99
100 --- 101
100 --- 102
100 --- 103
100 --- 104
100 --- 105
100 --- 106
100 --- 107
100 --- 108
100 --- 109
100 --- 110
100 --- 111
100 --- 112
100 --- 113
100 --- 114
106 --- 119
106 --- 126
106 --- 129
106 --- 132
106 --- 135
108 <--x 115
110 <--x 116
112 <--x 117
114 <--x 118
88 --- 91
88 --- 92
88 --- 93
88 --- 94
88 --- 95
88 --- 96
88 --- 97
88 --- 98
94 --- 103
94 --- 110
94 --- 113
94 --- 116
94 --- 119
95 <--x 90
95 <--x 94
96 <--x 91
96 <--x 94
97 <--x 92
97 <--x 94
98 <--x 99
103 --- 104
103 --- 105
103 --- 106
103 --- 107
103 --- 108
103 ---- 122
103 --- 109
104 --- 123
104 --- 132
104 x--> 127
105 --- 124
105 --- 129
105 x--> 127
106 --- 125
106 --- 130
106 x--> 127
107 --- 126
107 --- 131
107 x--> 127
110 --- 111
110 --- 112
113 --- 114
113 --- 115
116 --- 117
116 --- 118
119 --- 120
119 --- 121
119 --- 122
119 --- 123
119 --- 124
119 ---- 138
119 --- 125
120 --- 139
120 --- 145
120 --- 146
121 --- 140
121 --- 147
121 --- 148
122 --- 141
122 --- 149
122 --- 150
123 --- 142
123 --- 151
123 --- 152
126 --- 127
126 --- 128
129 --- 130
129 --- 131
132 --- 133
132 --- 134
135 --- 136
135 --- 137
138 --- 139
138 --- 140
138 --- 141
138 --- 142
138 --- 143
138 --- 144
138 --- 145
138 --- 146
138 --- 147
138 --- 148
138 --- 149
138 --- 150
138 --- 151
138 --- 152
146 <--x 153
148 <--x 154
150 <--x 155
152 <--x 156
106 <--x 157
122 --- 123
122 --- 124
122 --- 125
122 --- 126
122 --- 127
122 --- 128
122 --- 129
122 --- 130
122 --- 131
122 --- 132
129 <--x 124
129 <--x 128
130 <--x 125
130 <--x 128
131 <--x 126
131 <--x 128
132 <--x 133
94 <--x 137
```