getCommonEdge as default way of filleting (#6043)

* Common edge faces into artifact graph * clean up * kingdom of tags * add tests * hook up tags with edge treatments * update unit tests * update e2e * clean up * more fix up after main merge * fmt * revolve fix * fix new circular dependency * fix revolve * remove numbers from circ deps, makes diffs bad * sim test updates * try and get tests working * update * Fix tsc error --------- Co-authored-by: max-mrgrsk <156543465+max-mrgrsk@users.noreply.github.com> Co-authored-by: max <margorskyi@gmail.com> Co-authored-by: Jonathan Tran <jonnytran@gmail.com>
2025-04-26 14:00:28 +10:00
parent 50f8131d83
commit 8de648f0db
224 changed files with 157661 additions and 42680 deletions
--- a/rust/kcl-lib/tests/kcl_samples/gridfinity-baseplate-magnets/artifact_graph_flowchart.snap.md
+++ b/rust/kcl-lib/tests/kcl_samples/gridfinity-baseplate-magnets/artifact_graph_flowchart.snap.md
@ -9,77 +9,77 @@ flowchart LR
    7["Segment<br>[1124, 1131, 0]"]
    8[Solid2d]
  end
-  subgraph path28 [Path]
-    28["Path<br>[922, 947, 0]"]
-    29["Segment<br>[955, 977, 0]"]
-    30["Segment<br>[985, 1029, 0]"]
-    31["Segment<br>[1037, 1064, 0]"]
-    32["Segment<br>[1072, 1116, 0]"]
-    33["Segment<br>[1124, 1131, 0]"]
-    34[Solid2d]
+  subgraph path22 [Path]
+    22["Path<br>[922, 947, 0]"]
+    23["Segment<br>[955, 977, 0]"]
+    24["Segment<br>[985, 1029, 0]"]
+    25["Segment<br>[1037, 1064, 0]"]
+    26["Segment<br>[1072, 1116, 0]"]
+    27["Segment<br>[1124, 1131, 0]"]
+    28[Solid2d]
  end
-  subgraph path54 [Path]
-    54["Path<br>[4583, 4663, 0]"]
-    55["Segment<br>[4583, 4663, 0]"]
-    56[Solid2d]
+  subgraph path42 [Path]
+    42["Path<br>[4583, 4663, 0]"]
+    43["Segment<br>[4583, 4663, 0]"]
+    44[Solid2d]
  end
-  subgraph path58 [Path]
-    58["Path<br>[4214, 4239, 0]"]
-    59["Segment<br>[4247, 4288, 0]"]
-    60["Segment<br>[4296, 4337, 0]"]
-    61["Segment<br>[4345, 4398, 0]"]
-    62["Segment<br>[4406, 4427, 0]"]
-    63[Solid2d]
+  subgraph path46 [Path]
+    46["Path<br>[4214, 4239, 0]"]
+    47["Segment<br>[4247, 4288, 0]"]
+    48["Segment<br>[4296, 4337, 0]"]
+    49["Segment<br>[4345, 4398, 0]"]
+    50["Segment<br>[4406, 4427, 0]"]
+    51[Solid2d]
  end
-  subgraph path65 [Path]
-    65["Path<br>[2723, 2810, 0]"]
-    66["Segment<br>[2818, 2897, 0]"]
-    67["Segment<br>[2905, 2970, 0]"]
-    68["Segment<br>[2978, 3060, 0]"]
-    69["Segment<br>[3068, 3114, 0]"]
-    70["Segment<br>[3122, 3201, 0]"]
-    71["Segment<br>[3209, 3276, 0]"]
-    72["Segment<br>[3284, 3363, 0]"]
-    73["Segment<br>[3371, 3417, 0]"]
-    74["Segment<br>[3425, 3507, 0]"]
-    75["Segment<br>[3515, 3583, 0]"]
-    76["Segment<br>[3591, 3670, 0]"]
-    77["Segment<br>[3678, 3743, 0]"]
-    78["Segment<br>[3751, 3833, 0]"]
-    79["Segment<br>[3841, 3909, 0]"]
-    80["Segment<br>[3917, 3999, 0]"]
-    81["Segment<br>[4007, 4056, 0]"]
-    82["Segment<br>[4064, 4071, 0]"]
-    83[Solid2d]
+  subgraph path53 [Path]
+    53["Path<br>[2723, 2810, 0]"]
+    54["Segment<br>[2818, 2897, 0]"]
+    55["Segment<br>[2905, 2970, 0]"]
+    56["Segment<br>[2978, 3060, 0]"]
+    57["Segment<br>[3068, 3114, 0]"]
+    58["Segment<br>[3122, 3201, 0]"]
+    59["Segment<br>[3209, 3276, 0]"]
+    60["Segment<br>[3284, 3363, 0]"]
+    61["Segment<br>[3371, 3417, 0]"]
+    62["Segment<br>[3425, 3507, 0]"]
+    63["Segment<br>[3515, 3583, 0]"]
+    64["Segment<br>[3591, 3670, 0]"]
+    65["Segment<br>[3678, 3743, 0]"]
+    66["Segment<br>[3751, 3833, 0]"]
+    67["Segment<br>[3841, 3909, 0]"]
+    68["Segment<br>[3917, 3999, 0]"]
+    69["Segment<br>[4007, 4056, 0]"]
+    70["Segment<br>[4064, 4071, 0]"]
+    71[Solid2d]
  end
-  subgraph path100 [Path]
-    100["Path<br>[4214, 4239, 0]"]
-    101["Segment<br>[4247, 4288, 0]"]
-    102["Segment<br>[4296, 4337, 0]"]
-    103["Segment<br>[4345, 4398, 0]"]
-    104["Segment<br>[4406, 4427, 0]"]
-    105[Solid2d]
+  subgraph path84 [Path]
+    84["Path<br>[4214, 4239, 0]"]
+    85["Segment<br>[4247, 4288, 0]"]
+    86["Segment<br>[4296, 4337, 0]"]
+    87["Segment<br>[4345, 4398, 0]"]
+    88["Segment<br>[4406, 4427, 0]"]
+    89[Solid2d]
  end
-  subgraph path106 [Path]
-    106["Path<br>[2723, 2810, 0]"]
-    107["Segment<br>[2818, 2897, 0]"]
-    108["Segment<br>[2905, 2970, 0]"]
-    109["Segment<br>[2978, 3060, 0]"]
-    110["Segment<br>[3068, 3114, 0]"]
-    111["Segment<br>[3122, 3201, 0]"]
-    112["Segment<br>[3209, 3276, 0]"]
-    113["Segment<br>[3284, 3363, 0]"]
-    114["Segment<br>[3371, 3417, 0]"]
-    115["Segment<br>[3425, 3507, 0]"]
-    116["Segment<br>[3515, 3583, 0]"]
-    117["Segment<br>[3591, 3670, 0]"]
-    118["Segment<br>[3678, 3743, 0]"]
-    119["Segment<br>[3751, 3833, 0]"]
-    120["Segment<br>[3841, 3909, 0]"]
-    121["Segment<br>[3917, 3999, 0]"]
-    122["Segment<br>[4007, 4056, 0]"]
-    123["Segment<br>[4064, 4071, 0]"]
-    124[Solid2d]
+  subgraph path90 [Path]
+    90["Path<br>[2723, 2810, 0]"]
+    91["Segment<br>[2818, 2897, 0]"]
+    92["Segment<br>[2905, 2970, 0]"]
+    93["Segment<br>[2978, 3060, 0]"]
+    94["Segment<br>[3068, 3114, 0]"]
+    95["Segment<br>[3122, 3201, 0]"]
+    96["Segment<br>[3209, 3276, 0]"]
+    97["Segment<br>[3284, 3363, 0]"]
+    98["Segment<br>[3371, 3417, 0]"]
+    99["Segment<br>[3425, 3507, 0]"]
+    100["Segment<br>[3515, 3583, 0]"]
+    101["Segment<br>[3591, 3670, 0]"]
+    102["Segment<br>[3678, 3743, 0]"]
+    103["Segment<br>[3751, 3833, 0]"]
+    104["Segment<br>[3841, 3909, 0]"]
+    105["Segment<br>[3917, 3999, 0]"]
+    106["Segment<br>[4007, 4056, 0]"]
+    107["Segment<br>[4064, 4071, 0]"]
+    108[Solid2d]
  end
  1["Plane<br>[1217, 1255, 0]"]
  9["Sweep Extrusion<br>[1204, 1298, 0]"]
@ -91,80 +91,60 @@ flowchart LR
  15["Cap Start"]
  16["Cap End"]
  17["SweepEdge Opposite"]
-  18["SweepEdge Adjacent"]
+  18["SweepEdge Opposite"]
  19["SweepEdge Opposite"]
-  20["SweepEdge Adjacent"]
-  21["SweepEdge Opposite"]
-  22["SweepEdge Adjacent"]
-  23["SweepEdge Opposite"]
-  24["SweepEdge Adjacent"]
-  25["SweepEdge Opposite"]
-  26["SweepEdge Adjacent"]
-  27["Plane<br>[1711, 1749, 0]"]
-  35["Sweep Revolve<br>[1698, 1780, 0]"]
-  36[Wall]
-  37[Wall]
-  38[Wall]
-  39[Wall]
-  40[Wall]
-  41["Cap Start"]
-  42["Cap End"]
-  43["SweepEdge Opposite"]
-  44["SweepEdge Adjacent"]
-  45["SweepEdge Opposite"]
-  46["SweepEdge Adjacent"]
-  47["SweepEdge Opposite"]
-  48["SweepEdge Adjacent"]
-  49["SweepEdge Opposite"]
-  50["SweepEdge Adjacent"]
-  51["SweepEdge Opposite"]
-  52["SweepEdge Adjacent"]
-  53["Plane<br>[4560, 4577, 0]"]
-  57["Plane<br>[4186, 4206, 0]"]
-  64["Plane<br>[2695, 2715, 0]"]
-  84["Sweep Extrusion<br>[5006, 5048, 0]"]
-  85[Wall]
-  86[Wall]
-  87[Wall]
-  88[Wall]
-  89["Cap Start"]
-  90["Cap End"]
-  91["SweepEdge Opposite"]
-  92["SweepEdge Adjacent"]
-  93["SweepEdge Opposite"]
-  94["SweepEdge Adjacent"]
-  95["SweepEdge Opposite"]
-  96["SweepEdge Adjacent"]
-  97["SweepEdge Opposite"]
-  98["SweepEdge Adjacent"]
-  99["Plane<br>[5542, 5577, 0]"]
-  125["Sweep Extrusion<br>[5660, 5711, 0]"]
-  126[Wall]
-  127[Wall]
-  128[Wall]
-  129[Wall]
-  130["Cap Start"]
-  131["Cap End"]
-  132["SweepEdge Opposite"]
-  133["SweepEdge Adjacent"]
-  134["SweepEdge Opposite"]
-  135["SweepEdge Adjacent"]
-  136["SweepEdge Opposite"]
-  137["SweepEdge Adjacent"]
-  138["SweepEdge Opposite"]
-  139["SweepEdge Adjacent"]
-  140["EdgeCut Fillet<br>[5111, 5450, 0]"]
-  141["EdgeCut Fillet<br>[5111, 5450, 0]"]
-  142["EdgeCut Fillet<br>[5111, 5450, 0]"]
-  143["EdgeCut Fillet<br>[5111, 5450, 0]"]
-  144["EdgeCut Fillet<br>[5775, 6119, 0]"]
-  145["EdgeCut Fillet<br>[5775, 6119, 0]"]
-  146["EdgeCut Fillet<br>[5775, 6119, 0]"]
-  147["EdgeCut Fillet<br>[5775, 6119, 0]"]
-  148["StartSketchOnPlane<br>[894, 914, 0]"]
-  149["StartSketchOnPlane<br>[894, 914, 0]"]
-  150["StartSketchOnPlane<br>[4186, 4206, 0]"]
-  151["StartSketchOnPlane<br>[2695, 2715, 0]"]
+  20["SweepEdge Opposite"]
+  21["Plane<br>[1711, 1749, 0]"]
+  29["Sweep Revolve<br>[1698, 1780, 0]"]
+  30[Wall]
+  31[Wall]
+  32[Wall]
+  33[Wall]
+  34[Wall]
+  35["Cap Start"]
+  36["Cap End"]
+  37["SweepEdge Opposite"]
+  38["SweepEdge Opposite"]
+  39["SweepEdge Opposite"]
+  40["SweepEdge Opposite"]
+  41["Plane<br>[4560, 4577, 0]"]
+  45["Plane<br>[4186, 4206, 0]"]
+  52["Plane<br>[2695, 2715, 0]"]
+  72["Sweep Extrusion<br>[5006, 5048, 0]"]
+  73[Wall]
+  74[Wall]
+  75[Wall]
+  76[Wall]
+  77["Cap Start"]
+  78["Cap End"]
+  79["SweepEdge Opposite"]
+  80["SweepEdge Opposite"]
+  81["SweepEdge Opposite"]
+  82["SweepEdge Adjacent"]
+  83["Plane<br>[5542, 5577, 0]"]
+  109["Sweep Extrusion<br>[5660, 5711, 0]"]
+  110[Wall]
+  111[Wall]
+  112[Wall]
+  113[Wall]
+  114["Cap Start"]
+  115["Cap End"]
+  116["SweepEdge Opposite"]
+  117["SweepEdge Opposite"]
+  118["SweepEdge Opposite"]
+  119["SweepEdge Adjacent"]
+  120["EdgeCut Fillet<br>[5111, 5450, 0]"]
+  121["EdgeCut Fillet<br>[5111, 5450, 0]"]
+  122["EdgeCut Fillet<br>[5111, 5450, 0]"]
+  123["EdgeCut Fillet<br>[5111, 5450, 0]"]
+  124["EdgeCut Fillet<br>[5775, 6119, 0]"]
+  125["EdgeCut Fillet<br>[5775, 6119, 0]"]
+  126["EdgeCut Fillet<br>[5775, 6119, 0]"]
+  127["EdgeCut Fillet<br>[5775, 6119, 0]"]
+  128["StartSketchOnPlane<br>[894, 914, 0]"]
+  129["StartSketchOnPlane<br>[894, 914, 0]"]
+  130["StartSketchOnPlane<br>[4186, 4206, 0]"]
+  131["StartSketchOnPlane<br>[2695, 2715, 0]"]
  1 --- 2
  2 --- 3
  2 --- 4
@ -174,20 +154,19 @@ flowchart LR
  2 ---- 9
  2 --- 8
  3 --- 14
-  3 --- 25
-  3 --- 26
+  3 --- 20
+  3 x--> 15
  4 --- 13
-  4 --- 23
-  4 --- 24
+  4 --- 19
+  4 x--> 15
  5 --- 12
-  5 --- 21
-  5 --- 22
+  5 --- 18
+  5 x--> 15
  6 --- 11
-  6 --- 19
-  6 --- 20
+  6 --- 17
+  6 x--> 15
  7 --- 10
-  7 --- 17
-  7 --- 18
+  7 x--> 15
  9 --- 10
  9 --- 11
  9 --- 12
@ -199,169 +178,170 @@ flowchart LR
  9 --- 18
  9 --- 19
  9 --- 20
-  9 --- 21
-  9 --- 22
-  9 --- 23
-  9 --- 24
-  9 --- 25
-  9 --- 26
-  27 --- 28
-  28 --- 29
-  28 --- 30
-  28 --- 31
-  28 --- 32
-  28 --- 33
-  28 ---- 35
-  28 --- 34
+  17 <--x 11
+  17 <--x 16
+  18 <--x 12
+  18 <--x 16
+  19 <--x 13
+  19 <--x 16
+  20 <--x 14
+  20 <--x 16
+  21 --- 22
+  22 --- 23
+  22 --- 24
+  22 --- 25
+  22 --- 26
+  22 --- 27
+  22 ---- 29
+  22 --- 28
+  23 --- 30
+  23 x--> 35
+  24 --- 31
+  24 --- 37
+  24 x--> 35
+  25 --- 32
+  25 --- 38
+  25 x--> 35
+  26 --- 33
+  26 --- 39
+  26 x--> 35
+  27 --- 34
+  27 --- 40
+  27 x--> 35
+  29 --- 30
+  29 --- 31
+  29 --- 32
+  29 --- 33
+  29 --- 34
+  29 --- 35
  29 --- 36
-  29 --- 43
-  29 --- 44
-  30 --- 37
-  30 --- 45
-  30 --- 46
-  31 --- 38
-  31 --- 47
-  31 --- 48
-  32 --- 39
-  32 --- 49
-  32 --- 50
-  33 --- 40
-  33 --- 51
-  33 --- 52
-  35 --- 36
-  35 --- 37
-  35 --- 38
-  35 --- 39
-  35 --- 40
-  35 --- 41
-  35 --- 42
-  35 --- 43
-  35 --- 44
-  35 --- 45
-  35 --- 46
-  35 --- 47
-  35 --- 48
-  35 --- 49
-  35 --- 50
-  35 --- 51
-  35 --- 52
+  29 --- 37
+  29 --- 38
+  29 --- 39
+  29 --- 40
+  37 <--x 31
+  37 <--x 36
+  38 <--x 32
+  38 <--x 36
+  39 <--x 33
+  39 <--x 36
+  40 <--x 34
+  40 <--x 36
+  41 --- 42
+  42 --- 43
+  42 --- 44
+  45 --- 46
+  46 --- 47
+  46 --- 48
+  46 --- 49
+  46 --- 50
+  46 ---- 72
+  46 --- 51
+  47 --- 73
+  47 --- 82
+  47 x--> 78
+  48 --- 74
+  48 --- 79
+  48 x--> 78
+  49 --- 75
+  49 --- 80
+  49 x--> 78
+  50 --- 76
+  50 --- 81
+  50 x--> 78
+  52 --- 53
  53 --- 54
-  54 --- 55
-  54 --- 56
-  57 --- 58
-  58 --- 59
-  58 --- 60
-  58 --- 61
-  58 --- 62
-  58 ---- 84
-  58 --- 63
-  59 --- 85
-  59 --- 91
-  59 --- 92
-  60 --- 86
-  60 --- 93
-  60 --- 94
-  61 --- 87
-  61 --- 95
-  61 --- 96
-  62 --- 88
-  62 --- 97
-  62 --- 98
-  64 --- 65
-  65 --- 66
-  65 --- 67
-  65 --- 68
-  65 --- 69
-  65 --- 70
-  65 --- 71
-  65 --- 72
-  65 --- 73
-  65 --- 74
-  65 --- 75
-  65 --- 76
-  65 --- 77
-  65 --- 78
-  65 --- 79
-  65 --- 80
-  65 --- 81
-  65 --- 82
-  65 --- 83
+  53 --- 55
+  53 --- 56
+  53 --- 57
+  53 --- 58
+  53 --- 59
+  53 --- 60
+  53 --- 61
+  53 --- 62
+  53 --- 63
+  53 --- 64
+  53 --- 65
+  53 --- 66
+  53 --- 67
+  53 --- 68
+  53 --- 69
+  53 --- 70
+  53 --- 71
+  72 --- 73
+  72 --- 74
+  72 --- 75
+  72 --- 76
+  72 --- 77
+  72 --- 78
+  72 --- 79
+  72 --- 80
+  72 --- 81
+  72 --- 82
+  79 <--x 74
+  79 <--x 77
+  80 <--x 75
+  80 <--x 77
+  81 <--x 76
+  81 <--x 77
+  83 --- 84
+  83 --- 90
  84 --- 85
  84 --- 86
  84 --- 87
  84 --- 88
+  84 ---- 109
  84 --- 89
-  84 --- 90
-  84 --- 91
-  84 --- 92
-  84 --- 93
-  84 --- 94
-  84 --- 95
-  84 --- 96
-  84 --- 97
-  84 --- 98
-  99 --- 100
-  99 --- 106
-  100 --- 101
-  100 --- 102
-  100 --- 103
-  100 --- 104
-  100 ---- 125
-  100 --- 105
-  101 --- 126
-  101 --- 132
-  101 --- 133
-  102 --- 127
-  102 --- 134
-  102 --- 135
-  103 --- 128
-  103 --- 136
-  103 --- 137
-  104 --- 129
-  104 --- 138
-  104 --- 139
-  106 --- 107
-  106 --- 108
-  106 --- 109
-  106 --- 110
-  106 --- 111
-  106 --- 112
-  106 --- 113
-  106 --- 114
-  106 --- 115
-  106 --- 116
-  106 --- 117
-  106 --- 118
-  106 --- 119
-  106 --- 120
-  106 --- 121
-  106 --- 122
-  106 --- 123
-  106 --- 124
-  125 --- 126
-  125 --- 127
-  125 --- 128
-  125 --- 129
-  125 --- 130
-  125 --- 131
-  125 --- 132
-  125 --- 133
-  125 --- 134
-  125 --- 135
-  125 --- 136
-  125 --- 137
-  125 --- 138
-  125 --- 139
-  92 <--x 140
-  98 <--x 141
-  96 <--x 142
-  94 <--x 143
-  133 <--x 144
-  139 <--x 145
-  137 <--x 146
-  135 <--x 147
-  1 <--x 148
-  27 <--x 149
-  99 <--x 150
-  99 <--x 151
+  85 --- 110
+  85 --- 119
+  85 x--> 115
+  86 --- 111
+  86 --- 116
+  86 x--> 115
+  87 --- 112
+  87 --- 117
+  87 x--> 115
+  88 --- 113
+  88 --- 118
+  88 x--> 115
+  90 --- 91
+  90 --- 92
+  90 --- 93
+  90 --- 94
+  90 --- 95
+  90 --- 96
+  90 --- 97
+  90 --- 98
+  90 --- 99
+  90 --- 100
+  90 --- 101
+  90 --- 102
+  90 --- 103
+  90 --- 104
+  90 --- 105
+  90 --- 106
+  90 --- 107
+  90 --- 108
+  109 --- 110
+  109 --- 111
+  109 --- 112
+  109 --- 113
+  109 --- 114
+  109 --- 115
+  109 --- 116
+  109 --- 117
+  109 --- 118
+  109 --- 119
+  116 <--x 111
+  116 <--x 114
+  117 <--x 112
+  117 <--x 114
+  118 <--x 113
+  118 <--x 114
+  82 <--x 120
+  119 <--x 124
+  1 <--x 128
+  21 <--x 129
+  83 <--x 130
+  83 <--x 131
 ```