getCommonEdge as default way of filleting (#6043)

* Common edge faces into artifact graph

* clean up

* kingdom of tags

* add tests

* hook up tags with edge treatments

* update unit tests

* update e2e

* clean up

* more fix up after main merge

* fmt

* revolve fix

* fix new circular dependency

* fix revolve

* remove numbers from circ deps, makes diffs bad

* sim test updates

* try and get tests working

* update

* Fix tsc error

---------

Co-authored-by: max-mrgrsk <156543465+max-mrgrsk@users.noreply.github.com>
Co-authored-by: max <margorskyi@gmail.com>
Co-authored-by: Jonathan Tran <jonnytran@gmail.com>

rust/kcl-lib/tests/sketch-on-chamfer-two-times/artifact_graph_flowchart.snap.md

@@ -9,23 +9,23 @@ flowchart LR
     7["Segment<br>[438, 446, 0]"]
     8[Solid2d]
   end
-  subgraph path27 [Path]
-    27["Path<br>[721, 755, 0]"]
-    28["Segment<br>[761, 827, 0]"]
-    29["Segment<br>[833, 931, 0]"]
-    30["Segment<br>[937, 1054, 0]"]
-    31["Segment<br>[1060, 1116, 0]"]
-    32["Segment<br>[1122, 1130, 0]"]
-    33[Solid2d]
+  subgraph path22 [Path]
+    22["Path<br>[721, 755, 0]"]
+    23["Segment<br>[761, 827, 0]"]
+    24["Segment<br>[833, 931, 0]"]
+    25["Segment<br>[937, 1054, 0]"]
+    26["Segment<br>[1060, 1116, 0]"]
+    27["Segment<br>[1122, 1130, 0]"]
+    28[Solid2d]
   end
-  subgraph path34 [Path]
-    34["Path<br>[1188, 1223, 0]"]
-    35["Segment<br>[1229, 1295, 0]"]
-    36["Segment<br>[1301, 1400, 0]"]
-    37["Segment<br>[1406, 1523, 0]"]
-    38["Segment<br>[1529, 1585, 0]"]
-    39["Segment<br>[1591, 1599, 0]"]
-    40[Solid2d]
+  subgraph path29 [Path]
+    29["Path<br>[1188, 1223, 0]"]
+    30["Segment<br>[1229, 1295, 0]"]
+    31["Segment<br>[1301, 1400, 0]"]
+    32["Segment<br>[1406, 1523, 0]"]
+    33["Segment<br>[1529, 1585, 0]"]
+    34["Segment<br>[1591, 1599, 0]"]
+    35[Solid2d]
   end
   1["Plane<br>[12, 31, 0]"]
   9["Sweep Extrusion<br>[460, 492, 0]"]
@@ -36,32 +36,22 @@ flowchart LR
   14["Cap Start"]
   15["Cap End"]
   16["SweepEdge Opposite"]
-  17["SweepEdge Adjacent"]
+  17["SweepEdge Opposite"]
   18["SweepEdge Opposite"]
-  19["SweepEdge Adjacent"]
-  20["SweepEdge Opposite"]
-  21["SweepEdge Adjacent"]
-  22["SweepEdge Opposite"]
-  23["SweepEdge Adjacent"]
-  24["EdgeCut Fillet<br>[498, 533, 0]"]
-  25["Plane<br>[721, 755, 0]"]
-  26["Plane<br>[1188, 1223, 0]"]
-  41["Sweep Extrusion<br>[1613, 1644, 0]"]
-  42[Wall]
-  43[Wall]
-  44[Wall]
-  45[Wall]
-  46["Cap End"]
-  47["SweepEdge Opposite"]
-  48["SweepEdge Adjacent"]
-  49["SweepEdge Opposite"]
-  50["SweepEdge Adjacent"]
-  51["SweepEdge Opposite"]
-  52["SweepEdge Adjacent"]
-  53["SweepEdge Opposite"]
-  54["SweepEdge Adjacent"]
-  55["StartSketchOnFace<br>[676, 715, 0]"]
-  56["StartSketchOnFace<br>[1143, 1182, 0]"]
+  19["EdgeCut Fillet<br>[498, 533, 0]"]
+  20["Plane<br>[721, 755, 0]"]
+  21["Plane<br>[1188, 1223, 0]"]
+  36["Sweep Extrusion<br>[1613, 1644, 0]"]
+  37[Wall]
+  38[Wall]
+  39[Wall]
+  40[Wall]
+  41["Cap End"]
+  42["SweepEdge Opposite"]
+  43["SweepEdge Opposite"]
+  44["SweepEdge Opposite"]
+  45["StartSketchOnFace<br>[676, 715, 0]"]
+  46["StartSketchOnFace<br>[1143, 1182, 0]"]
   1 --- 2
   2 --- 3
   2 --- 4
@@ -71,19 +61,18 @@ flowchart LR
   2 ---- 9
   2 --- 8
   3 --- 13
-  3 --- 22
-  3 --- 23
+  3 --- 18
+  3 x--> 14
   4 --- 12
-  4 --- 20
-  4 --- 21
-  4 --- 24
+  4 --- 17
+  4 --- 19
+  4 x--> 14
   5 --- 11
-  5 --- 18
-  5 --- 19
+  5 --- 16
+  5 x--> 14
   6 --- 10
-  6 --- 16
-  6 --- 17
-  6 x--> 25
+  6 x--> 20
+  6 x--> 14
   9 --- 10
   9 --- 11
   9 --- 12
@@ -93,51 +82,50 @@ flowchart LR
   9 --- 16
   9 --- 17
   9 --- 18
-  9 --- 19
-  9 --- 20
-  9 --- 21
-  9 --- 22
-  9 --- 23
-  25 --- 27
-  26 --- 34
-  27 --- 28
-  27 --- 29
-  27 --- 30
-  27 --- 31
-  27 --- 32
-  27 --- 33
-  34 --- 35
-  34 --- 36
-  34 --- 37
-  34 --- 38
-  34 --- 39
-  34 ---- 41
-  34 --- 40
-  35 --- 45
-  35 --- 53
-  35 --- 54
+  16 <--x 11
+  16 <--x 15
+  18 <--x 13
+  18 <--x 15
+  20 --- 22
+  21 --- 29
+  22 --- 23
+  22 --- 24
+  22 --- 25
+  22 --- 26
+  22 --- 27
+  22 --- 28
+  29 --- 30
+  29 --- 31
+  29 --- 32
+  29 --- 33
+  29 --- 34
+  29 ---- 36
+  29 --- 35
+  30 --- 40
+  30 --- 44
+  30 <--x 21
+  31 --- 39
+  31 --- 43
+  31 <--x 21
+  32 --- 38
+  32 --- 42
+  32 <--x 21
+  33 --- 37
+  33 <--x 21
+  36 --- 37
+  36 --- 38
+  36 --- 39
+  36 --- 40
+  36 --- 41
+  36 --- 42
+  36 --- 43
   36 --- 44
-  36 --- 51
-  36 --- 52
-  37 --- 43
-  37 --- 49
-  37 --- 50
-  38 --- 42
-  38 --- 47
-  38 --- 48
-  41 --- 42
-  41 --- 43
-  41 --- 44
-  41 --- 45
-  41 --- 46
-  41 --- 47
-  41 --- 48
-  41 --- 49
-  41 --- 50
-  41 --- 51
-  41 --- 52
-  41 --- 53
-  41 --- 54
-  25 <--x 55
-  26 <--x 56
+  42 <--x 38
+  42 <--x 41
+  43 <--x 39
+  43 <--x 41
+  44 <--x 40
+  44 <--x 41
+  20 <--x 45
+  21 <--x 46
 ```